sync/protocol/proto_value_conversions.cc - Issue 17038002: Separate the NTP app ordering from the app list app ordering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 17038002: Separate the NTP app ordering from the app list app ordering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rework + fix tests Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/protocol/proto_value_conversions.cc

diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc

index f4fe44d10b2fb9897fee9666fa115d32c93c5e6b..fd2c0be571b11424952384d81d1a81a7dcbabbb7 100644

--- a/sync/protocol/proto_value_conversions.cc

+++ b/sync/protocol/proto_value_conversions.cc

@@ -298,6 +298,7 @@ base::DictionaryValue* AppSpecificsToValue(

SET(notification_settings, AppSettingsToValue);

SET_STR(app_launch_ordinal);

SET_STR(page_ordinal);

+ SET_STR(app_list_ordinal);

return value;

}

« chrome/browser/ui/app_list/app_list_extension_sorting_unittest.cc ('K') | « sync/protocol/app_specifics.proto ('k') | no next file » | no next file with comments »