Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/browser/ui/app_list/extension_app_item.h

Issue 17038002: Separate the NTP app ordering from the app list app ordering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework + fix tests Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/extension_app_item.h
diff --git a/chrome/browser/ui/app_list/extension_app_item.h b/chrome/browser/ui/app_list/extension_app_item.h
index d2c4b098bbf8f5f4f0cbb5c697e9da1808b4d8e5..6a8a4e521078589a94f62a1511e8e7664caf3c0f 100644
--- a/chrome/browser/ui/app_list/extension_app_item.h
+++ b/chrome/browser/ui/app_list/extension_app_item.h
@@ -45,9 +45,6 @@ class ExtensionAppItem : public ChromeAppListItem,
// Reload the title and icon from the underlying extension.
void Reload();
- syncer::StringOrdinal GetPageOrdinal() const;
- syncer::StringOrdinal GetAppLaunchOrdinal() const;
-
// Update page and app launcher ordinals to put the app in between |prev| and
// |next|. Note that |prev| and |next| could be NULL when the app is put at
// the beginning or at the end.
@@ -57,6 +54,14 @@ class ExtensionAppItem : public ChromeAppListItem,
// it gray.
void UpdateIcon();
+ // Returns true if this ExtensionAppItem precedes |item| in the app list app
+ // ordering. The item's extension id must be in the app list ordering.
+ bool Precedes(const ExtensionAppItem* item) const;
+
+ // Returns true if thie ExtensionAppItem's extension id is in the app list app
+ // ordering.
+ bool ExistsInSorting();
+
const std::string& extension_id() const { return extension_id_; }
private:

Powered by Google App Engine
This is Rietveld 408576698