Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: Source/core/inspector/CodeGeneratorInspectorStrings.py

Issue 17030009: Inspector: wrapped inspector agent instances into factory-like wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Made InspectorBaseAgent RefCounted Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/CodeGeneratorInspectorStrings.py
diff --git a/Source/core/inspector/CodeGeneratorInspectorStrings.py b/Source/core/inspector/CodeGeneratorInspectorStrings.py
index 6c3fe05a1f087c9cde2e101d1808da175b533a5a..74c698c662728107cba0cf5079500b52c15a2efb 100644
--- a/Source/core/inspector/CodeGeneratorInspectorStrings.py
+++ b/Source/core/inspector/CodeGeneratorInspectorStrings.py
@@ -48,14 +48,15 @@ backend_method = (
{
RefPtr<InspectorArray> protocolErrors = InspectorArray::create();
- if (!$agentField)
+ $handlerClass* handler = $agentField ? $agentField->getCommandHandler() : 0;
+ if (!handler)
protocolErrors->pushString("${domainName} handler is not available.");
$methodOutCode
$methodInCode
RefPtr<InspectorObject> result = InspectorObject::create();
ErrorString error;
if (!protocolErrors->length()) {
- $agentField->$methodName(&error$agentCallParams);
+ handler->$methodName(&error$agentCallParams);
${responseCook}
}

Powered by Google App Engine
This is Rietveld 408576698