Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: Source/core/inspector/InspectorResourceAgent.h

Issue 17030009: Inspector: wrapped inspector agent instances into factory-like wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorProfilerAgent.cpp ('k') | Source/core/inspector/InspectorResourceAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorResourceAgent.h
diff --git a/Source/core/inspector/InspectorResourceAgent.h b/Source/core/inspector/InspectorResourceAgent.h
index 40827c633658bbee10a01509a1850ae7968fdc1a..448f18c214f4af5fe43cefef2812bf41270f39fe 100644
--- a/Source/core/inspector/InspectorResourceAgent.h
+++ b/Source/core/inspector/InspectorResourceAgent.h
@@ -59,6 +59,7 @@ class InspectorClient;
class InspectorFrontend;
class InspectorObject;
class InspectorPageAgent;
+class InspectorPageFactory;
class InspectorState;
class InstrumentingAgents;
class KURL;
@@ -79,20 +80,15 @@ class WebSocketHandshakeResponse;
typedef String ErrorString;
-class InspectorResourceAgent : public InspectorBaseAgent<InspectorResourceAgent>, public InspectorBackendDispatcher::NetworkCommandHandler {
+class InspectorResourceAgent : public InspectorBaseAgent, public InspectorBackendDispatcher::NetworkCommandHandler {
public:
- static PassOwnPtr<InspectorResourceAgent> create(InstrumentingAgents* instrumentingAgents, InspectorPageAgent* pageAgent, InspectorClient* client, InspectorCompositeState* state)
- {
- return adoptPtr(new InspectorResourceAgent(instrumentingAgents, pageAgent, client, state));
- }
+ static PassRefPtr<InspectorResourceAgent> create(InstrumentingAgents*, InspectorState*, PassRefPtr<InspectorPageAgent>, InspectorClient*);
virtual void setFrontend(InspectorFrontend*);
virtual void clearFrontend();
virtual void restore();
- static PassRefPtr<InspectorResourceAgent> restore(Page*, InspectorCompositeState*, InspectorFrontend*);
-
- ~InspectorResourceAgent();
+ virtual ~InspectorResourceAgent();
void willSendRequest(unsigned long identifier, DocumentLoader*, ResourceRequest&, const ResourceResponse& redirectResponse, const CachedResourceInitiatorInfo&);
void markResourceAsCached(unsigned long identifier);
@@ -154,11 +150,11 @@ public:
virtual void reportMemoryUsage(MemoryObjectInfo*) const OVERRIDE;
private:
- InspectorResourceAgent(InstrumentingAgents*, InspectorPageAgent*, InspectorClient*, InspectorCompositeState*);
+ InspectorResourceAgent(InstrumentingAgents*, InspectorState*, PassRefPtr<InspectorPageAgent>, InspectorClient*);
void enable();
- InspectorPageAgent* m_pageAgent;
+ RefPtr<InspectorPageAgent> m_pageAgent;
InspectorClient* m_client;
InspectorFrontend::Network* m_frontend;
String m_userAgentOverride;
@@ -172,6 +168,18 @@ private:
bool m_isRecalculatingStyle;
};
+class InspectorResourceFactory : public InspectorBaseFactory<InspectorResourceFactory, InspectorResourceAgent> {
+public:
+
+ static PassOwnPtr<InspectorResourceFactory> create(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* compositeState, InspectorPageFactory* pageFactory, InspectorClient* client)
+ {
+ return adoptPtr(new InspectorResourceFactory(instrumentingAgents, compositeState, pageFactory, client));
+ }
+
+protected:
+ InspectorResourceFactory(InstrumentingAgents*, InspectorCompositeState*, InspectorPageFactory*, InspectorClient*);
+};
+
} // namespace WebCore
« no previous file with comments | « Source/core/inspector/InspectorProfilerAgent.cpp ('k') | Source/core/inspector/InspectorResourceAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698