Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: Source/core/inspector/InspectorDatabaseAgent.h

Issue 17030009: Inspector: wrapped inspector agent instances into factory-like wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDatabaseAgent.h
diff --git a/Source/core/inspector/InspectorDatabaseAgent.h b/Source/core/inspector/InspectorDatabaseAgent.h
index 190e0043302e325dfe54d845e81217ded33ee334..60e48540ebb843955738e2f9e44f3099c8648f71 100644
--- a/Source/core/inspector/InspectorDatabaseAgent.h
+++ b/Source/core/inspector/InspectorDatabaseAgent.h
@@ -48,13 +48,13 @@ class InstrumentingAgents;
typedef String ErrorString;
-class InspectorDatabaseAgent : public InspectorBaseAgent<InspectorDatabaseAgent>, public InspectorBackendDispatcher::DatabaseCommandHandler {
+class InspectorDatabaseAgent : public InspectorBaseAgent, public InspectorBackendDispatcher::DatabaseCommandHandler {
public:
- static PassOwnPtr<InspectorDatabaseAgent> create(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* state)
+ static PassRefPtr<InspectorDatabaseAgent> create(InstrumentingAgents* instrumentingAgents, InspectorState* state)
{
- return adoptPtr(new InspectorDatabaseAgent(instrumentingAgents, state));
+ return adoptRef(new InspectorDatabaseAgent(instrumentingAgents, state));
}
- ~InspectorDatabaseAgent();
+ virtual ~InspectorDatabaseAgent();
virtual void setFrontend(InspectorFrontend*);
virtual void clearFrontend();
@@ -73,7 +73,7 @@ public:
void didOpenDatabase(PassRefPtr<Database>, const String& domain, const String& name, const String& version);
private:
- explicit InspectorDatabaseAgent(InstrumentingAgents*, InspectorCompositeState*);
+ explicit InspectorDatabaseAgent(InstrumentingAgents*, InspectorState*);
Database* databaseForId(const String& databaseId);
InspectorDatabaseResource* findByFileName(const String& fileName);
@@ -84,6 +84,22 @@ private:
bool m_enabled;
};
+class InspectorDatabaseFactory : public InspectorBaseFactory<InspectorDatabaseFactory, InspectorDatabaseAgent> {
+public:
+
+ static PassOwnPtr<InspectorDatabaseFactory> create(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* compositeState)
+ {
+ return adoptPtr(new InspectorDatabaseFactory(instrumentingAgents, compositeState));
+ }
+
+protected:
+ InspectorDatabaseFactory(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* compositeState)
+ : InspectorBaseFactory<InspectorDatabaseFactory, InspectorDatabaseAgent>("Database", instrumentingAgents, compositeState)
+ {
+ setAgent(InspectorDatabaseAgent::create(m_instrumentingAgents, m_state));
+ }
+};
+
} // namespace WebCore
#endif // !defined(InspectorDatabaseAgent_h)
« no previous file with comments | « Source/core/inspector/InspectorDOMStorageAgent.cpp ('k') | Source/core/inspector/InspectorDatabaseAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698