Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 17030009: Inspector: wrapped inspector agent instances into factory-like wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMDebuggerAgent.h
diff --git a/Source/core/inspector/InspectorDOMDebuggerAgent.h b/Source/core/inspector/InspectorDOMDebuggerAgent.h
index d925081b03230d2f3ae27c6bc73483b67b49fbf7..9d3056ae77ecc3a0a9a38407d0cf21ce72b45f3b 100644
--- a/Source/core/inspector/InspectorDOMDebuggerAgent.h
+++ b/Source/core/inspector/InspectorDOMDebuggerAgent.h
@@ -45,6 +45,7 @@ class Document;
class Element;
class Event;
class InspectorDOMAgent;
+class InspectorDOMFactory;
class InspectorDebuggerAgent;
class InspectorFrontend;
class InspectorObject;
@@ -54,10 +55,10 @@ class Node;
typedef String ErrorString;
-class InspectorDOMDebuggerAgent : public InspectorBaseAgent<InspectorDOMDebuggerAgent>, public InspectorDebuggerAgent::Listener, public InspectorBackendDispatcher::DOMDebuggerCommandHandler {
+class InspectorDOMDebuggerAgent : public InspectorBaseAgent, public InspectorDebuggerAgent::Listener, public InspectorBackendDispatcher::DOMDebuggerCommandHandler {
WTF_MAKE_NONCOPYABLE(InspectorDOMDebuggerAgent);
public:
- static PassOwnPtr<InspectorDOMDebuggerAgent> create(InstrumentingAgents*, InspectorCompositeState*, InspectorDOMAgent*, InspectorDebuggerAgent*);
+ static PassRefPtr<InspectorDOMDebuggerAgent> create(InstrumentingAgents*, InspectorState*, PassRefPtr<InspectorDOMAgent>, PassRefPtr<InspectorDebuggerAgent>);
virtual ~InspectorDOMDebuggerAgent();
@@ -94,7 +95,7 @@ public:
virtual void discardAgent();
private:
- InspectorDOMDebuggerAgent(InstrumentingAgents*, InspectorCompositeState*, InspectorDOMAgent*, InspectorDebuggerAgent*);
+ InspectorDOMDebuggerAgent(InstrumentingAgents*, InspectorState*, PassRefPtr<InspectorDOMAgent>, PassRefPtr<InspectorDebuggerAgent>);
void pauseOnNativeEventIfNeeded(PassRefPtr<InspectorObject> eventData, bool synchronous);
PassRefPtr<InspectorObject> preparePauseOnNativeEventData(bool isDOMEvent, const String& eventName);
@@ -115,12 +116,24 @@ private:
void clear();
- InspectorDOMAgent* m_domAgent;
- InspectorDebuggerAgent* m_debuggerAgent;
+ RefPtr<InspectorDOMAgent> m_domAgent;
+ RefPtr<InspectorDebuggerAgent> m_debuggerAgent;
HashMap<Node*, uint32_t> m_domBreakpoints;
bool m_pauseInNextEventListener;
};
+class InspectorDOMDebuggerFactory : public InspectorBaseFactory<InspectorDOMDebuggerFactory, InspectorDOMDebuggerAgent> {
+public:
+
+ static PassOwnPtr<InspectorDOMDebuggerFactory> create(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* compositeState, InspectorDOMFactory* domFactory, InspectorDebuggerFactory * debuggerFactory)
+ {
+ return adoptPtr(new InspectorDOMDebuggerFactory(instrumentingAgents, compositeState, domFactory, debuggerFactory));
+ }
+
+protected:
+ InspectorDOMDebuggerFactory(InstrumentingAgents*, InspectorCompositeState*, InspectorDOMFactory*, InspectorDebuggerFactory*);
+};
+
} // namespace WebCore
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698