Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 17030009: Inspector: wrapped inspector agent instances into factory-like wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMDebuggerAgent.h ('k') | Source/core/inspector/InspectorDOMStorageAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMDebuggerAgent.cpp
diff --git a/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
index b955bb9b3fc84f8bc976f2eb775082c8c1ab7b08..1b3db6ec5cd7f3f6d776b0d967fc015597f0f59f 100644
--- a/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
+++ b/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
@@ -73,13 +73,13 @@ static const char pauseOnAllXHRs[] = "pauseOnAllXHRs";
static const char xhrBreakpoints[] = "xhrBreakpoints";
}
-PassOwnPtr<InspectorDOMDebuggerAgent> InspectorDOMDebuggerAgent::create(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* inspectorState, InspectorDOMAgent* domAgent, InspectorDebuggerAgent* debuggerAgent)
+PassRefPtr<InspectorDOMDebuggerAgent> InspectorDOMDebuggerAgent::create(InstrumentingAgents* instrumentingAgents, InspectorState* inspectorState, PassRefPtr<InspectorDOMAgent> domAgent, PassRefPtr<InspectorDebuggerAgent> debuggerAgent)
{
- return adoptPtr(new InspectorDOMDebuggerAgent(instrumentingAgents, inspectorState, domAgent, debuggerAgent));
+ return adoptRef(new InspectorDOMDebuggerAgent(instrumentingAgents, inspectorState, domAgent, debuggerAgent));
}
-InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* inspectorState, InspectorDOMAgent* domAgent, InspectorDebuggerAgent* debuggerAgent)
- : InspectorBaseAgent<InspectorDOMDebuggerAgent>("DOMDebugger", instrumentingAgents, inspectorState)
+InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorState* inspectorState, PassRefPtr<InspectorDOMAgent> domAgent, PassRefPtr<InspectorDebuggerAgent> debuggerAgent)
+ : InspectorBaseAgent(instrumentingAgents, inspectorState)
, m_domAgent(domAgent)
, m_debuggerAgent(debuggerAgent)
, m_pauseInNextEventListener(false)
@@ -503,5 +503,11 @@ void InspectorDOMDebuggerAgent::clear()
m_pauseInNextEventListener = false;
}
+InspectorDOMDebuggerFactory::InspectorDOMDebuggerFactory(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* compositeState, InspectorDOMFactory* domFactory, InspectorDebuggerFactory* debuggerFactory)
+ : InspectorBaseFactory<InspectorDOMDebuggerFactory, InspectorDOMDebuggerAgent>("DOMDebugger", instrumentingAgents, compositeState)
+{
+ setAgent(InspectorDOMDebuggerAgent::create(m_instrumentingAgents, m_state, domFactory->agent(), debuggerFactory->agent()));
+}
+
} // namespace WebCore
« no previous file with comments | « Source/core/inspector/InspectorDOMDebuggerAgent.h ('k') | Source/core/inspector/InspectorDOMStorageAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698