Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: Source/core/inspector/PageConsoleAgent.h

Issue 17030009: Inspector: wrapped inspector agent instances into factory-like wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 #ifndef PageConsoleAgent_h 31 #ifndef PageConsoleAgent_h
32 #define PageConsoleAgent_h 32 #define PageConsoleAgent_h
33 33
34 #include "core/inspector/InspectorConsoleAgent.h" 34 #include "core/inspector/InspectorConsoleAgent.h"
35 #include <wtf/PassOwnPtr.h> 35 #include <wtf/PassOwnPtr.h>
36 36
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 class InspectorDOMAgent; 40 class InspectorDOMAgent;
41 class InspectorDOMFactory;
41 42
42 class PageConsoleAgent : public InspectorConsoleAgent { 43 class PageConsoleAgent : public InspectorConsoleAgent {
43 WTF_MAKE_NONCOPYABLE(PageConsoleAgent); 44 WTF_MAKE_NONCOPYABLE(PageConsoleAgent);
44 public: 45 public:
45 static PassOwnPtr<PageConsoleAgent> create(InstrumentingAgents* instrumentin gAgents, InspectorCompositeState* state, InjectedScriptManager* injectedScriptMa nager, InspectorDOMAgent* domAgent) 46 static PassRefPtr<PageConsoleAgent> create(InstrumentingAgents*, InspectorSt ate*, InjectedScriptManager*, PassRefPtr<InspectorDOMAgent>);
46 {
47 return adoptPtr(new PageConsoleAgent(instrumentingAgents, state, injecte dScriptManager, domAgent));
48 }
49 virtual ~PageConsoleAgent(); 47 virtual ~PageConsoleAgent();
50 48
51 virtual bool isWorkerAgent() OVERRIDE { return false; } 49 virtual bool isWorkerAgent() OVERRIDE { return false; }
52 50
53 private: 51 private:
54 PageConsoleAgent(InstrumentingAgents*, InspectorCompositeState*, InjectedScr iptManager*, InspectorDOMAgent*); 52 PageConsoleAgent(InstrumentingAgents*, InspectorState*, InjectedScriptManage r*, PassRefPtr<InspectorDOMAgent>);
55 virtual void clearMessages(ErrorString*); 53 virtual void clearMessages(ErrorString*);
56 virtual void addInspectedNode(ErrorString*, int nodeId); 54 virtual void addInspectedNode(ErrorString*, int nodeId);
57 55
58 InspectorDOMAgent* m_inspectorDOMAgent; 56 RefPtr<InspectorDOMAgent> m_inspectorDOMAgent;
57 };
58
59 class PageConsoleFactory : public InspectorConsoleFactory {
60 public:
61
62 static PassOwnPtr<PageConsoleFactory> create(InstrumentingAgents* instrument ingAgents, InspectorCompositeState* compositeState, InjectedScriptManager* injec tedScriptManager, InspectorDOMFactory* domFactory)
63 {
64 return adoptPtr(new PageConsoleFactory(instrumentingAgents, compositeSta te, injectedScriptManager, domFactory));
65 }
66
67 protected:
68 PageConsoleFactory(InstrumentingAgents*, InspectorCompositeState*, InjectedS criptManager*, InspectorDOMFactory*);
59 }; 69 };
60 70
61 } // namespace WebCore 71 } // namespace WebCore
62 72
63 73
64 #endif // !defined(PageConsoleAgent_h) 74 #endif // !defined(PageConsoleAgent_h)
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorWorkerAgent.cpp ('k') | Source/core/inspector/PageConsoleAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698