Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: Source/core/inspector/PageConsoleAgent.cpp

Issue 17030009: Inspector: wrapped inspector agent instances into factory-like wrappers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/PageConsoleAgent.h ('k') | Source/core/inspector/PageDebuggerAgent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 #include "core/inspector/PageConsoleAgent.h" 32 #include "core/inspector/PageConsoleAgent.h"
33 33
34 #include "core/dom/Node.h" 34 #include "core/dom/Node.h"
35 #include "core/dom/shadow/ShadowRoot.h" 35 #include "core/dom/shadow/ShadowRoot.h"
36 #include "core/inspector/InjectedScriptHost.h" 36 #include "core/inspector/InjectedScriptHost.h"
37 #include "core/inspector/InjectedScriptManager.h" 37 #include "core/inspector/InjectedScriptManager.h"
38 #include "core/inspector/InspectorDOMAgent.h" 38 #include "core/inspector/InspectorDOMAgent.h"
39 39
40 namespace WebCore { 40 namespace WebCore {
41 41
42 PageConsoleAgent::PageConsoleAgent(InstrumentingAgents* instrumentingAgents, Ins pectorCompositeState* state, InjectedScriptManager* injectedScriptManager, Inspe ctorDOMAgent* domAgent) 42 PassRefPtr<PageConsoleAgent> PageConsoleAgent::create(InstrumentingAgents* instr umentingAgents, InspectorState* state, InjectedScriptManager* injectedScriptMana ger, PassRefPtr<InspectorDOMAgent> domAgent)
43 {
44 return adoptRef(new PageConsoleAgent(instrumentingAgents, state, injectedScr iptManager, domAgent));
45 }
46
47 PageConsoleAgent::PageConsoleAgent(InstrumentingAgents* instrumentingAgents, Ins pectorState* state, InjectedScriptManager* injectedScriptManager, PassRefPtr<Ins pectorDOMAgent> domAgent)
43 : InspectorConsoleAgent(instrumentingAgents, state, injectedScriptManager) 48 : InspectorConsoleAgent(instrumentingAgents, state, injectedScriptManager)
44 , m_inspectorDOMAgent(domAgent) 49 , m_inspectorDOMAgent(domAgent)
45 { 50 {
46 } 51 }
47 52
48 PageConsoleAgent::~PageConsoleAgent() 53 PageConsoleAgent::~PageConsoleAgent()
49 { 54 {
50 m_inspectorDOMAgent = 0; 55 m_inspectorDOMAgent = 0;
51 } 56 }
52 57
(...skipping 24 matching lines...) Expand all
77 while (node->isInShadowTree()) { 82 while (node->isInShadowTree()) {
78 Node* ancestor = node->highestAncestor(); 83 Node* ancestor = node->highestAncestor();
79 if (!ancestor->isShadowRoot() || toShadowRoot(ancestor)->type() == Shado wRoot::AuthorShadowRoot) 84 if (!ancestor->isShadowRoot() || toShadowRoot(ancestor)->type() == Shado wRoot::AuthorShadowRoot)
80 break; 85 break;
81 // User agent shadow root, keep climbing up. 86 // User agent shadow root, keep climbing up.
82 node = toShadowRoot(ancestor)->host(); 87 node = toShadowRoot(ancestor)->host();
83 } 88 }
84 m_injectedScriptManager->injectedScriptHost()->addInspectedObject(adoptPtr(n ew InspectableNode(node))); 89 m_injectedScriptManager->injectedScriptHost()->addInspectedObject(adoptPtr(n ew InspectableNode(node)));
85 } 90 }
86 91
92 PageConsoleFactory::PageConsoleFactory(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* compositeState, InjectedScriptManager* injectedScriptM anager, InspectorDOMFactory* domFactory)
93 : InspectorConsoleFactory(instrumentingAgents, compositeState)
94 {
95 setAgent(PageConsoleAgent::create(m_instrumentingAgents, m_state, injectedSc riptManager, domFactory->agent()));
96 }
97
87 } // namespace WebCore 98 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/inspector/PageConsoleAgent.h ('k') | Source/core/inspector/PageDebuggerAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698