linux_aura: Redo how memory is handled in clipboard/drag code.

linux_aura: Redo how memory is handled in clipboard/drag code.

This changes the ownership model from manually allocated arrays to
RefCountedMemory segments. Coincidentally, this also reduces the number
of memcpys by letting us pass around data sent to us by the X server.

BUG=130806
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208342

[Elliot Glaysher, 2013-06-24 19:34:24]

Here's the promised follow up patch that changes the ownership structure.

This patch has the added benefit of reducing the number of copies made; since
everything is a RefCountedMemory segment now, I created a specific
RefCountedMemory subclass that owns a piece of X11 allocated memory.

[sky, 2013-06-24 20:36:18]

https://codereview.chromium.org/17029020/diff/1/ui/base/clipboard/clipboard_a...
File ui/base/clipboard/clipboard_aurax11.cc (right):

https://codereview.chromium.org/17029020/diff/1/ui/base/clipboard/clipboard_a...
ui/base/clipboard/clipboard_aurax11.cc:356: } else {
nit: style guide says no else when you have a return.

https://codereview.chromium.org/17029020/diff/1/ui/base/x/selection_utils.cc
File ui/base/x/selection_utils.cc (right):

https://codereview.chromium.org/17029020/diff/1/ui/base/x/selection_utils.cc#...
ui/base/x/selection_utils.cc:77: NOTREACHED();
Is an empty string not legal?

https://codereview.chromium.org/17029020/diff/1/ui/base/x/x11_util.h
File ui/base/x/x11_util.h (right):

https://codereview.chromium.org/17029020/diff/1/ui/base/x/x11_util.h#newcode343
ui/base/x/x11_util.h:343: explicit XRefcountedMemory(unsigned char* x11_data,
size_t length)
nit: no explicit

https://codereview.chromium.org/17029020/diff/1/ui/base/x/x11_util.h#newcode344
ui/base/x/x11_util.h:344: : x11_data_(length ? x11_data : NULL), length_(length)
{}
nit: one param per line when you wrap.

[Elliot Glaysher, 2013-06-24 20:53:53]

Fixes for sky; ptal

[Elliot Glaysher, 2013-06-24 20:54:35]

(it looks like the command line didn't publish drafts. le sigh.)

https://codereview.chromium.org/17029020/diff/1/ui/base/clipboard/clipboard_a...
File ui/base/clipboard/clipboard_aurax11.cc (right):

https://codereview.chromium.org/17029020/diff/1/ui/base/clipboard/clipboard_a...
ui/base/clipboard/clipboard_aurax11.cc:356: } else {
On 2013/06/24 20:36:18, sky wrote:
> nit: style guide says no else when you have a return.

Changed above instance, too, while I'm here.

https://codereview.chromium.org/17029020/diff/1/ui/base/x/selection_utils.cc
File ui/base/x/selection_utils.cc (right):

https://codereview.chromium.org/17029020/diff/1/ui/base/x/selection_utils.cc#...
ui/base/x/selection_utils.cc:77: NOTREACHED();
On 2013/06/24 20:36:18, sky wrote:
> Is an empty string not legal?

I want to say that it's impossible, but I'm not actually sure that I can,
because other clients are providing the data. Removed the NOTREACHED() here and
in the next function.

[sky, 2013-06-24 20:55:58]

LGTM

[commit-bot: I haz the power, 2013-06-24 20:58:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/17029020/23002

[commit-bot: I haz the power, 2013-06-25 01:18:11]

Change committed as 208342