Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 17028017: Flexible representation for BuildIncrement, but CannotBeTagged. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Flexible representation for BuildIncrement, but CannotBeTagged. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15244

Patch Set 1 : #

Patch Set 2 : Let inferrepr figure out the repr of the add #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M src/hydrogen.cc View 1 4 chunks +12 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 6 months ago (2013-06-14 16:04:58 UTC) #1
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-06-18 09:43:46 UTC) #2
Toon Verwaest
7 years, 6 months ago (2013-06-20 13:22:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15244 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698