Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 17028007: Merge the HttpNetworkTransaction tests and parametrize them on a NextProto (Closed)

Created:
7 years, 6 months ago by akalin
Modified:
7 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Merge the HttpNetworkTransaction tests and parametrize them on a NextProto Add (partial) support for SPDY/3.1 and SPDY/4a2 for HttpNetworkTransaction unit tests. BUG=226192 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+535 lines, -23166 lines) Patch
M net/http/http_network_transaction.h View 1 chunk +5 lines, -7 lines 0 comments Download
D net/http/http_network_transaction_spdy2_unittest.cc View 1 chunk +0 lines, -11412 lines 0 comments Download
D net/http/http_network_transaction_spdy3_unittest.cc View 1 chunk +0 lines, -11365 lines 0 comments Download
A + net/http/http_network_transaction_unittest.cc View 214 chunks +506 lines, -380 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+rch for review This was easier than I thought!
7 years, 6 months ago (2013-06-14 02:28:00 UTC) #1
Ryan Hamilton
lgtm
7 years, 6 months ago (2013-06-14 14:22:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/17028007/1
7 years, 6 months ago (2013-06-14 14:25:03 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 16:08:04 UTC) #4
Message was sent while issue was closed.
Change committed as 206424

Powered by Google App Engine
This is Rietveld 408576698