Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: Source/devtools/front_end/SettingsScreen.js

Issue 170273003: DevTools: Implement extensions-based shortcut bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased patch Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 704 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 715
716 resize: function() 716 resize: function()
717 { 717 {
718 if (this._settingsScreen && this._settingsScreen.isShowing()) 718 if (this._settingsScreen && this._settingsScreen.isShowing())
719 this._settingsScreen.doResize(); 719 this._settingsScreen.doResize();
720 } 720 }
721 } 721 }
722 722
723 /** 723 /**
724 * @constructor 724 * @constructor
725 * @implements {WebInspector.ActionDelegate}
726 */
727 WebInspector.SettingsController.SettingsScreenActionDelegate = function() { }
728
729 WebInspector.SettingsController.SettingsScreenActionDelegate.prototype = {
730 /**
731 * @param {!KeyboardEvent=} keyEvent
732 * @return {boolean}
733 */
734 handleAction: function(keyEvent)
735 {
736 WebInspector.settingsController.showSettingsScreen(!!keyEvent ? WebInspe ctor.SettingsScreen.Tabs.General : undefined);
pfeldman 2014/03/24 16:54:22 How can there be no keyEvent?
apavlov 2014/03/25 10:03:45 That was a provisional version to handle both keyb
737 return true;
738 }
739 }
740
741 /**
742 * @constructor
725 * @extends {WebInspector.Object} 743 * @extends {WebInspector.Object}
726 * @param {function(!Element, string, ?string)} itemRenderer 744 * @param {function(!Element, string, ?string)} itemRenderer
727 */ 745 */
728 WebInspector.SettingsList = function(columns, itemRenderer) 746 WebInspector.SettingsList = function(columns, itemRenderer)
729 { 747 {
730 this.element = document.createElement("div"); 748 this.element = document.createElement("div");
731 this.element.classList.add("settings-list"); 749 this.element.classList.add("settings-list");
732 this.element.tabIndex = -1; 750 this.element.tabIndex = -1;
733 this._itemRenderer = itemRenderer; 751 this._itemRenderer = itemRenderer;
734 this._listItems = {}; 752 this._listItems = {};
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
1102 var inputElement = this._addInputElements[columnId]; 1120 var inputElement = this._addInputElements[columnId];
1103 inputElement.value = ""; 1121 inputElement.value = "";
1104 } 1122 }
1105 }, 1123 },
1106 1124
1107 __proto__: WebInspector.SettingsList.prototype 1125 __proto__: WebInspector.SettingsList.prototype
1108 } 1126 }
1109 1127
1110 /** @type {!WebInspector.SettingsController} */ 1128 /** @type {!WebInspector.SettingsController} */
1111 WebInspector.settingsController; 1129 WebInspector.settingsController;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698