Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Issue 17027007: Install a generic handler whenever we fail to update the IC. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Install a generic handler whenever we fail to update the IC. Ignore select cases in StoreIC since we don't have premonomorphic. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -27 lines) Patch
M src/arm/ic-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/ic.cc View 5 chunks +29 lines, -17 lines 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 6 months ago (2013-06-14 09:33:01 UTC) #1
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-06-14 11:16:58 UTC) #2
Toon Verwaest
7 years, 6 months ago (2013-06-14 11:21:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15145 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698