Pass InitializeCDM() call through IPC to the browser.

Pass InitializeCDM() call through IPC to the browser.

TBR=yfriedman@chromium.org
BUG=252042
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207757

[xhwang, 2013-06-20 19:49:43]

This CL only adds a message and does nothing yet. Will hook the renderer side up
after qinmin's CL (https://codereview.chromium.org/17101027/) is landed. PTAL.

[qinmin, 2013-06-20 20:47:38]

https://codereview.chromium.org/17022008/diff/1/webkit/renderer/media/android...
File webkit/renderer/media/android/webmediaplayer_proxy_android.h (right):

https://codereview.chromium.org/17022008/diff/1/webkit/renderer/media/android...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:73: virtual void
InitializeCDM(int media_keys_id,
descriptions?

[xhwang, 2013-06-20 21:30:37]

https://codereview.chromium.org/17022008/diff/1/webkit/renderer/media/android...
File webkit/renderer/media/android/webmediaplayer_proxy_android.h (right):

https://codereview.chromium.org/17022008/diff/1/webkit/renderer/media/android...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:73: virtual void
InitializeCDM(int media_keys_id,
On 2013/06/20 20:47:38, qinmin wrote:
> descriptions?

Done.

[qinmin, 2013-06-20 21:58:50]

lgtm

[ddorwin, 2013-06-20 22:07:01]

https://codereview.chromium.org/17022008/diff/9001/content/common/media/media...
File content/common/media/media_player_messages_android.h (right):

https://codereview.chromium.org/17022008/diff/9001/content/common/media/media...
content/common/media/media_player_messages_android.h:222:
IPC_MESSAGE_ROUTED3(MediaPlayerHostMsg_GenerateKeyRequest,
Should the prefix be changed to MediaKeysHostMsg?

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
File webkit/renderer/media/android/webmediaplayer_proxy_android.h (right):

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:73: // Informs the
MediaPlayerManager that a CDM that supports |uuid| should be
"Informs" is weird. Tells? Can we just say "Initializes a CDM that..."? Isn't
the MediaPlayerManager part an implementation detail?

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:74: // created and
initialized. The CDM is assigned a |media_keys_id| for future
How is the |media_keys_id| reported to the caller for future use?

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:76: virtual void
InitializeCDM(int media_keys_id,
How do we know this is successful? I guess error reporting is async anyway and
may not be known until you call createSession().

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:84: // Adds a key
to the CDM referenced by |media_keys_id|.
This is inaccurate for update(), but I guess we can fix that later?

[xhwang, 2013-06-21 00:50:13]

PTAnotherL

https://codereview.chromium.org/17022008/diff/9001/content/common/media/media...
File content/common/media/media_player_messages_android.h (right):

https://codereview.chromium.org/17022008/diff/9001/content/common/media/media...
content/common/media/media_player_messages_android.h:222:
IPC_MESSAGE_ROUTED3(MediaPlayerHostMsg_GenerateKeyRequest,
On 2013/06/20 22:07:01, ddorwin wrote:
> Should the prefix be changed to MediaKeysHostMsg?

Done.

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
File webkit/renderer/media/android/webmediaplayer_proxy_android.h (right):

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:73: // Informs the
MediaPlayerManager that a CDM that supports |uuid| should be
On 2013/06/20 22:07:01, ddorwin wrote:
> "Informs" is weird. Tells? Can we just say "Initializes a CDM that..."? Isn't
> the MediaPlayerManager part an implementation detail?

Done.

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:74: // created and
initialized. The CDM is assigned a |media_keys_id| for future
On 2013/06/20 22:07:01, ddorwin wrote:
> How is the |media_keys_id| reported to the caller for future use?

The renderer side allocates the |media_keys_id| and keep it.

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:76: virtual void
InitializeCDM(int media_keys_id,
On 2013/06/20 22:07:01, ddorwin wrote:
> How do we know this is successful? I guess error reporting is async anyway and
> may not be known until you call createSession().

Yes, it's async so we don't know. We could send a KeyError back. This is pretty
much the same issue as the pepper CDM.

https://codereview.chromium.org/17022008/diff/9001/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:84: // Adds a key
to the CDM referenced by |media_keys_id|.
On 2013/06/20 22:07:01, ddorwin wrote:
> This is inaccurate for update(), but I guess we can fix that later?

I still live in the V0.1b era :)

[ddorwin, 2013-06-21 00:54:34]

lgtm

https://codereview.chromium.org/17022008/diff/6008/webkit/renderer/media/andr...
File webkit/renderer/media/android/webmediaplayer_proxy_android.h (right):

https://codereview.chromium.org/17022008/diff/6008/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:73: // Initializes
a CDM that supports |uuid|.The CDM is assigned a
"is assigned" makes me think the callee generates it (even though it's an input
parameter). Maybe, "is stored" or something about the new CDM is associated with
that ID for future reference.

[xhwang, 2013-06-21 03:55:45]

https://codereview.chromium.org/17022008/diff/6008/webkit/renderer/media/andr...
File webkit/renderer/media/android/webmediaplayer_proxy_android.h (right):

https://codereview.chromium.org/17022008/diff/6008/webkit/renderer/media/andr...
webkit/renderer/media/android/webmediaplayer_proxy_android.h:73: // Initializes
a CDM that supports |uuid|.The CDM is assigned a
On 2013/06/21 00:54:34, ddorwin wrote:
> "is assigned" makes me think the callee generates it (even though it's an
input
> parameter). Maybe, "is stored" or something about the new CDM is associated
with
> that ID for future reference.

Done.

[commit-bot: I haz the power, 2013-06-21 03:56:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/17022008/22001

[commit-bot: I haz the power, 2013-06-21 04:17:48]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-21 04:41:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/17022008/22001

[commit-bot: I haz the power, 2013-06-21 08:49:58]

Change committed as 207757