Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 17009011: Automatically exclude *_win_browsertest.* from non-Windows builds. (Closed)

Created:
7 years, 6 months ago by Lei Zhang
Modified:
7 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Automatically exclude *_win_browsertest.* from non-Windows builds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207151

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M build/filename_rules.gypi View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
7 years, 6 months ago (2013-06-18 19:46:44 UTC) #1
Nico
lgtm, complimentary bikeshed below? https://codereview.chromium.org/17009011/diff/1/build/filename_rules.gypi File build/filename_rules.gypi (right): https://codereview.chromium.org/17009011/diff/1/build/filename_rules.gypi#newcode13 build/filename_rules.gypi:13: ['exclude', '_win(_browsertest)?\\.(h|cc)$'], No need for ...
7 years, 6 months ago (2013-06-18 19:49:23 UTC) #2
Nico
s/below\?/below:/ On Tue, Jun 18, 2013 at 12:49 PM, <thakis@chromium.org> wrote: > lgtm, complimentary bikeshed ...
7 years, 6 months ago (2013-06-18 19:49:46 UTC) #3
Lei Zhang
I made all the rules consistent.
7 years, 6 months ago (2013-06-18 20:07:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/17009011/6001
7 years, 6 months ago (2013-06-18 20:08:13 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-19 03:21:16 UTC) #6
Message was sent while issue was closed.
Change committed as 207151

Powered by Google App Engine
This is Rietveld 408576698