Don't show caret when containing element doesn't have focus

This patch changes to hide caret when editable element containing caret doesn't have focus.

- FrameSelection::didFocusChanged: For hiding caret at focus changed.
- FrameSelection::shouldBlinkCaret: For ease of reading to understand when caret will be blink.

BUG=222546
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153317

[yosin_UTC9, 2013-06-28 05:29:32]

Could you review this patch?
Thanks in advance.

[tkent, 2013-06-28 06:46:56]

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
File Source/core/editing/FrameSelection.cpp (right):

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
Source/core/editing/FrameSelection.cpp:1787: bool caretBrowsing =
m_frame->settings() && m_frame->settings()->caretBrowsingEnabled();
The variable 'caretBrowing' is not used.

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
Source/core/editing/FrameSelection.cpp:1878: return
focusedNode->containsIncludingShadowDOM(m_selection.start().deprecatedNode());
We should not use deprecatedNode in new code.

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
File Source/core/editing/FrameSelection.h (right):

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
Source/core/editing/FrameSelection.h:195: void didFocusChanged();
nit: The name should be didChangeFocus or focusWasChanged.

[yosin_UTC9, 2013-06-28 08:22:46]

PTAL

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
File Source/core/editing/FrameSelection.cpp (right):

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
Source/core/editing/FrameSelection.cpp:1787: bool caretBrowsing =
m_frame->settings() && m_frame->settings()->caretBrowsingEnabled();
On 2013/06/28 06:46:56, tkent wrote:
> The variable 'caretBrowing' is not used.

Done.

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
Source/core/editing/FrameSelection.cpp:1878: return
focusedNode->containsIncludingShadowDOM(m_selection.start().deprecatedNode());
On 2013/06/28 06:46:56, tkent wrote:
> We should not use deprecatedNode in new code.

Done.

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
File Source/core/editing/FrameSelection.h (right):

https://codereview.chromium.org/17005008/diff/5006/Source/core/editing/FrameS...
Source/core/editing/FrameSelection.h:195: void didFocusChanged();
On 2013/06/28 06:46:56, tkent wrote:
> nit: The name should be didChangeFocus or focusWasChanged.

Done.

[tkent, 2013-06-30 22:39:24]

lgtm

[commit-bot: I haz the power, 2013-07-01 01:26:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/17005008/15001

[commit-bot: I haz the power, 2013-07-01 03:18:00]

Change committed as 153317