Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17005006: Move PPB_VarArray and PPB_VarDictionary out of dev. (Closed)

Created:
7 years, 6 months ago by raymes
Modified:
7 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, raymes+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, ihf+watch_chromium.org, yzshen1
Visibility:
Public.

Description

Move PPB_VarArray and PPB_VarDictionary out of dev. Note that this completely removes the dev versions of the interfaces. The discussion on moving these interfaces to stable happened here: https://codereview.chromium.org/16136009 BUG=236958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207369

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : , #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+481 lines, -1022 lines) Patch
D ppapi/api/dev/ppb_var_array_dev.idl View 1 chunk +0 lines, -76 lines 0 comments Download
D ppapi/api/dev/ppb_var_dictionary_dev.idl View 1 chunk +0 lines, -89 lines 0 comments Download
A + ppapi/api/ppb_var_array.idl View 1 2 3 chunks +11 lines, -10 lines 0 comments Download
A + ppapi/api/ppb_var_dictionary.idl View 3 chunks +12 lines, -11 lines 0 comments Download
D ppapi/c/dev/ppb_var_array_dev.h View 1 chunk +0 lines, -94 lines 0 comments Download
D ppapi/c/dev/ppb_var_dictionary_dev.h View 1 chunk +0 lines, -106 lines 0 comments Download
A + ppapi/c/ppb_var_array.h View 4 chunks +16 lines, -15 lines 0 comments Download
A + ppapi/c/ppb_var_dictionary.h View 4 chunks +17 lines, -16 lines 0 comments Download
D ppapi/cpp/dev/var_array_dev.h View 1 chunk +0 lines, -90 lines 0 comments Download
D ppapi/cpp/dev/var_array_dev.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D ppapi/cpp/dev/var_dictionary_dev.h View 1 chunk +0 lines, -93 lines 0 comments Download
D ppapi/cpp/dev/var_dictionary_dev.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M ppapi/cpp/extensions/dev/alarms_dev.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ppapi/cpp/extensions/dev/socket_dev.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/extensions/dev/socket_dev.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M ppapi/cpp/extensions/dict_field.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M ppapi/cpp/extensions/ext_output_traits.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/cpp/extensions/from_var_converter.h View 4 chunks +8 lines, -8 lines 0 comments Download
M ppapi/cpp/extensions/to_var_converter.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + ppapi/cpp/var_array.h View 1 2 4 chunks +18 lines, -18 lines 0 comments Download
A ppapi/cpp/var_array.cc View 1 2 3 1 chunk +96 lines, -0 lines 0 comments Download
A + ppapi/cpp/var_dictionary.h View 1 2 3 chunks +20 lines, -20 lines 0 comments Download
A ppapi/cpp/var_dictionary.cc View 1 2 3 1 chunk +111 lines, -0 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 14 chunks +98 lines, -98 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_post_message.cc View 1 2 3 8 chunks +13 lines, -11 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_var_array_thunk.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ppapi/thunk/ppb_var_dictionary_thunk.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/common/plugins/ppapi/ppapi_utils.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
raymes
David, PTAL. I made this a separate CL to review because I'd like all the ...
7 years, 6 months ago (2013-06-16 23:40:47 UTC) #1
dmichael (off chromium)
lgtm
7 years, 6 months ago (2013-06-17 22:02:38 UTC) #2
dmichael (off chromium)
Oh, one request: please link to the original CL where all the discussion happened in ...
7 years, 6 months ago (2013-06-18 16:53:09 UTC) #3
raymes
On 2013/06/18 16:53:09, dmichael wrote: > Oh, one request: please link to the original CL ...
7 years, 6 months ago (2013-06-18 16:55:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/17005006/45001
7 years, 6 months ago (2013-06-19 16:15:54 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-19 16:25:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/17005006/64002
7 years, 6 months ago (2013-06-19 16:36:22 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-19 16:42:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/17005006/64002
7 years, 6 months ago (2013-06-19 16:48:04 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-19 16:52:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/17005006/64002
7 years, 6 months ago (2013-06-19 16:55:18 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-19 17:05:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/17005006/64002
7 years, 6 months ago (2013-06-19 18:25:01 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 09:08:17 UTC) #14
Message was sent while issue was closed. 
Change committed as 207369

Powered by Google App Engine
This is Rietveld 408576698