Issue 17005005: Reland "Make more GCs in idle notification handler."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17005005: Reland "Make more GCs in idle notification handler." (Closed)

Created:
7 years, 6 months ago by ulan

Modified:
7 years, 6 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reland "Make more GCs in idle notification handler." Fix performance regression on benchmarks by filtering out short idle notifications. R=hpayer@chromium.org BUG=241815 Committed: https://code.google.com/p/v8/source/detail?r=15160

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -14 lines)			Patch
	M	src/heap.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	src/heap.cc	View		5 chunks	+11 lines, -12 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM wiht one nit https://codereview.chromium.org/17005005/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/17005005/diff/1/src/heap.cc#newcode5875 src/heap.cc:5875: const int kMinHint = 10; ...

7 years, 6 months ago (2013-06-14 11:48:58 UTC) #2

ulan

Committed patchset #1 manually as r15160 (presubmit successful).

7 years, 6 months ago (2013-06-14 14:24:14 UTC) #3

ulan

7 years, 6 months ago (2013-06-14 14:24:20 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/17005005/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/17005005/diff/1/src/heap.cc#newcode5875
src/heap.cc:5875: const int kMinHint = 10;
On 2013/06/14 11:48:58, Hannes Payer wrote:
> Can we call that kMinHintForIncrementalMarking? This would be in sync with
> kMinHintForFullGC.

Done.

Expand Messages | Collapse Messages