Cleanup RepresentationFromUseRequirements, move it to HValue and use it where relevant

Cleanup RepresentationFromUseRequirements, move it to HValue and use it where relevant

BUG=
R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15155

[Toon Verwaest, 2013-06-14 11:07:48]

PTAL

[Jakob Kummerow, 2013-06-14 13:36:43]

lgtm

https://chromiumcodereview.appspot.com/17005004/diff/5001/src/hydrogen-instru...
File src/hydrogen-instructions.cc (right):

https://chromiumcodereview.appspot.com/17005004/diff/5001/src/hydrogen-instru...
src/hydrogen-instructions.cc:3673: for (HUseIterator it(uses()); !it.Done();
it.Advance()) {
Please add a high-level comment outlining the algorithm. E.g.:
// Check if all uses' requirements indicate that Integer32 is
// an appropriate representation for this value.

[Toon Verwaest, 2013-06-14 13:58:12]

Addressed comment

https://chromiumcodereview.appspot.com/17005004/diff/5001/src/hydrogen-instru...
File src/hydrogen-instructions.cc (right):

https://chromiumcodereview.appspot.com/17005004/diff/5001/src/hydrogen-instru...
src/hydrogen-instructions.cc:3673: for (HUseIterator it(uses()); !it.Done();
it.Advance()) {
On 2013/06/14 13:36:43, Jakob wrote:
> Please add a high-level comment outlining the algorithm. E.g.:
> // Check if all uses' requirements indicate that Integer32 is
> // an appropriate representation for this value.

Done.

[Toon Verwaest, 2013-06-14 14:13:54]

Committed patchset #4 manually as r15155 (presubmit successful).