Issue 17004010: PPAPI: Move PPB_NetworkProxy out of Dev

Issue 17004010: PPAPI: Move PPB_NetworkProxy out of Dev (Closed)

Created:
7 years, 6 months ago by dmichael (off chromium)

Modified:
7 years, 6 months ago

Reviewers:
noelallen1, bbudge, yzshen1, binji

CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Sam Clegg, piman+watch_chromium.org, binji, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI: Move PPB_NetworkProxy out of Dev This depends on the following CLs: https://codereview.chromium.org/17094022/ https://codereview.chromium.org/16819002/ BUG=247225 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208513

Patch Set 1 #

Patch Set 2 : Documentation #

Total comments: 2

Patch Set 3 : Add Permissions documentation #

Patch Set 4 : update library.dsc files in nacl sdk #

Patch Set 5 : merge #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -243 lines)			Patch
M	content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc	View	1 2 3 4	2 chunks	+9 lines, -9 lines	0 comments	Download
M	native_client_sdk/src/build_tools/sdk_files.list	View	1 2 3 4	3 chunks	+3 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/ppapi/library.dsc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/ppapi_cpp/library.dsc	View	1 2 3 4	2 chunks	+2 lines, -0 lines	0 comments	Download
D	ppapi/api/dev/ppb_network_proxy_dev.idl	View		1 chunk	+0 lines, -27 lines	0 comments	Download
A	ppapi/api/ppb_network_proxy.idl	View	1 2	1 chunk	+53 lines, -0 lines	0 comments	Download
D	ppapi/c/dev/ppb_network_proxy_dev.h	View		1 chunk	+0 lines, -49 lines	0 comments	Download
A	ppapi/c/ppb_network_proxy.h	View	1 2	1 chunk	+75 lines, -0 lines	0 comments	Download
D	ppapi/cpp/dev/network_proxy_dev.h	View		1 chunk	+0 lines, -28 lines	0 comments	Download
D	ppapi/cpp/dev/network_proxy_dev.cc	View		1 chunk	+0 lines, -38 lines	0 comments	Download
A	ppapi/cpp/network_proxy.h	View	1 2	1 chunk	+49 lines, -0 lines	0 comments	Download
A +	ppapi/cpp/network_proxy.cc	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	1 2 3 4	12 chunks	+22 lines, -22 lines	0 comments	Download
M	ppapi/ppapi_shared.gypi	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/ppapi_sources.gypi	View	1 2 3 4	4 chunks	+4 lines, -3 lines	0 comments	Download
M	ppapi/proxy/interface_list.cc	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download
M	ppapi/tests/all_c_includes.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/tests/all_cpp_includes.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/tests/test_network_proxy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/thunk/interfaces_ppb_public_dev.h	View	1 2 3 4	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/thunk/interfaces_ppb_public_stable.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
D	ppapi/thunk/ppb_network_proxy_dev_thunk.cc	View		1 chunk	+0 lines, -47 lines	0 comments	Download
A +	ppapi/thunk/ppb_network_proxy_thunk.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	webkit/common/plugins/ppapi/ppapi_utils.cc	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

bbudge1: everything noelallen: native_client_sdk

7 years, 6 months ago (2013-06-21 05:15:05 UTC) #1

yzshen1

https://codereview.chromium.org/17004010/diff/2001/ppapi/api/ppb_network_proxy.idl File ppapi/api/ppb_network_proxy.idl (right): https://codereview.chromium.org/17004010/diff/2001/ppapi/api/ppb_network_proxy.idl#newcode18 ppapi/api/ppb_network_proxy.idl:18: * for a given URL. For other APIs, I ...

7 years, 6 months ago (2013-06-21 06:45:40 UTC) #2

dmichael (off chromium)

Thanks for the super-fast reviews, guys! Updated. https://codereview.chromium.org/17004010/diff/2001/ppapi/api/ppb_network_proxy.idl File ppapi/api/ppb_network_proxy.idl (right): https://codereview.chromium.org/17004010/diff/2001/ppapi/api/ppb_network_proxy.idl#newcode18 ppapi/api/ppb_network_proxy.idl:18: * for ...

7 years, 6 months ago (2013-06-21 15:56:07 UTC) #4

yzshen1

On 2013/06/21 17:54:51, yzshen1 wrote: > LGTM > > Thanks! BTW, we now need to ...

7 years, 6 months ago (2013-06-21 19:11:01 UTC) #6

dmichael (off chromium)

binji, could you do an OWNERS review of native_client_sdk? Thanks!

7 years, 6 months ago (2013-06-21 19:51:42 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/17004010/15001

7 years, 6 months ago (2013-06-25 13:11:07 UTC) #9

Message was sent while issue was closed.

Change committed as 208513

Expand Messages | Collapse Messages