[SPDY] Fix SpdySession's handling of SYN_REPLY frames

[SPDY] Fix SpdySession's handling of SYN_REPLY frames

It sent the wrong error code for duplicate SYN_REPLY frames. Also,
it didn't trigger an error for data frames sent before SYN_REPLY.

Update tests to match.

Add {Active,Pushed}StreamInfo structs and use them in
{Active,Pushed}StreamMap.

Be defensive when closing expired push streams.

Give the correct name to SpdyHttpStream tests.

BUG=252556
R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207885

[akalin, 2013-06-21 02:12:23]

+rch for review

[Ryan Hamilton, 2013-06-21 15:35:37]

lgtm

https://chromiumcodereview.appspot.com/17004007/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (left):

https://chromiumcodereview.appspot.com/17004007/diff/1/net/spdy/spdy_session....
net/spdy/spdy_session.cc:1791:
RecordProtocolErrorHistogram(PROTOCOL_ERROR_SYN_REPLY_NOT_RECEIVED);
Did this get lost or is it called by LogStreamError or ResetSTream?

https://chromiumcodereview.appspot.com/17004007/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://chromiumcodereview.appspot.com/17004007/diff/1/net/spdy/spdy_session....
net/spdy/spdy_session.h:487: ActiveStreamInfo();
Is this constructor used explicitly, or only by of STL containers?

[akalin, 2013-06-21 18:30:44]

committing soon

https://chromiumcodereview.appspot.com/17004007/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (left):

https://chromiumcodereview.appspot.com/17004007/diff/1/net/spdy/spdy_session....
net/spdy/spdy_session.cc:1791:
RecordProtocolErrorHistogram(PROTOCOL_ERROR_SYN_REPLY_NOT_RECEIVED);
On 2013/06/21 15:35:37, Ryan Hamilton wrote:
> Did this get lost or is it called by LogStreamError or ResetSTream?

Called by ResetStream

https://chromiumcodereview.appspot.com/17004007/diff/1/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

https://chromiumcodereview.appspot.com/17004007/diff/1/net/spdy/spdy_session....
net/spdy/spdy_session.h:487: ActiveStreamInfo();
On 2013/06/21 15:35:37, Ryan Hamilton wrote:
> Is this constructor used explicitly, or only by of STL containers?

Just for STL, and to make sure that the member variables always start
initialized

[akalin, 2013-06-21 18:31:00]

Committed patchset #1 manually as r207885 (presubmit successful).