LayoutTests/media/track/track-disabled.html - Issue 17002002: TextTrackCue should check for non-NULL cue list pointer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/track-disabled.html

Issue 17002002: TextTrackCue should check for non-NULL cue list pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated aaron's comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src=../media-file.js></script>
	acolwell GONE FROM CHROMIUM 2013/06/27 23:51:53 nit: add 4 more spaces here and to everything else nit: add 4 more spaces here and to everything else in the <head>. It's 4 spaces per level. Sorry if I wasn't clear about that. also please add quotes around the script paths. Matthew Heaney (Chromium) 2013/06/28 00:05:59 Done. Show quoted text On 2013/06/27 23:51:53, acolwell wrote: > nit: add 4 more spaces here and to everything else in the <head>. It's 4 spaces > per level. Sorry if I wasn't clear about that. > > also please add quotes around the script paths. Done.
	5 <script src=../video-test.js></script>

	6 <script>

	7 if (window.testRunner)

	8 testRunner.dumpAsText();

	9

	10 waitForEvent('loadstart', function ()

	11 {

	12 var v = document.getElementById('vid');

	13 v.textTracks[0].mode = "disabled";

	14 });

	15

	16 waitForEventAndEnd('loadedmetadata');

	17 </script>

	18 </head>

	19 <body>

	20 <video id="vid" src="../content/test.ogv" autoplay controls>

	21 <track kind='subtitles' srclang='en' label='English' src='captions-w ebvtt/captions.vtt' />

	22 </video>

	23 </body>

	24 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/track/track-disabled-expected.txt » ('j') | no next file with comments »