Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: runtime/vm/service.cc

Issue 1699153002: Add step OverAwait to service protocol (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index c8912eb48c240e41cc2a646e40a21cbc6536d69c..d61a99d07da88d10c48003eb7136fede0407efae 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2629,7 +2629,7 @@ static bool AddBreakpointAtActivation(Thread* thread, JSONStream* js) {
}
const Instance& closure = Instance::Cast(obj);
Breakpoint* bpt =
- thread->isolate()->debugger()->SetBreakpointAtActivation(closure);
+ thread->isolate()->debugger()->SetBreakpointAtActivation(closure, false);
if (bpt == NULL) {
js->PrintError(kCannotAddBreakpoint,
"%s: Cannot add breakpoint at activation",
@@ -3020,6 +3020,12 @@ static bool Resume(Thread* thread, JSONStream* js) {
isolate->debugger()->SetStepOver();
} else if (strcmp(step_param, "Out") == 0) {
isolate->debugger()->SetStepOut();
+ } else if (strcmp(step_param, "OverAwait") == 0) {
+ if (!isolate->debugger()->SetupStepOverAwait()) {
+ js->PrintError(kInvalidParams,
+ "Isolate must be paused at an await statement.");
+ return true;
+ }
} else {
PrintInvalidParamError(js, "step");
return true;

Powered by Google App Engine
This is Rietveld 408576698