Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 16983014: components: Move autofill strings to autofill_strings.grdp. (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 6 months ago
Reviewers:
Jói
CC:
chromium-reviews
Visibility:
Public.

Description

components: Move autofill strings to autofill_strings.grdp. BUG=250213 R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208125

Patch Set 1 #

Patch Set 2 : update OWNERS file #

Patch Set 3 : sync+rebase+fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -101 lines) Patch
M components/OWNERS View 1 1 chunk +3 lines, -3 lines 0 comments Download
A components/autofill_strings.grdp View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
M components/component_strings.grd View 1 2 1 chunk +1 line, -98 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
7 years, 6 months ago (2013-06-20 23:10:40 UTC) #1
Jói
Perhaps update the OWNERS file also to use autofill* instead of autofill.gypi for per-file OWNERS. ...
7 years, 6 months ago (2013-06-21 11:24:53 UTC) #2
tfarina
Done. Please, take another look.
7 years, 6 months ago (2013-06-21 13:31:00 UTC) #3
Jói
LGTM, thanks.
7 years, 6 months ago (2013-06-21 13:31:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16983014/10001
7 years, 6 months ago (2013-06-23 01:57:11 UTC) #5
commit-bot: I haz the power
Failed to apply patch for components/component_strings.grd: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-23 01:57:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16983014/12002
7 years, 6 months ago (2013-06-23 02:11:35 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
7 years, 6 months ago (2013-06-23 06:56:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16983014/12002
7 years, 6 months ago (2013-06-23 12:21:52 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-23 14:11:05 UTC) #10
Message was sent while issue was closed.
Change committed as 208125

Powered by Google App Engine
This is Rietveld 408576698