Source/WebKit/chromium/src/WebPluginScrollbarImpl.cpp - Issue 16982005: Allow objects without scrollbars to be scrollable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebPluginScrollbarImpl.cpp

Issue 16982005: Allow objects without scrollbars to be scrollable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: CR Fixes Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebKit/chromium/src/ScrollbarGroup.cpp ('k') | Source/WebKit/chromium/tests/GraphicsLayerTest.cpp » ('j') | Source/core/platform/ScrollableArea.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebKit/chromium/src/WebPluginScrollbarImpl.cpp

diff --git a/Source/WebKit/chromium/src/WebPluginScrollbarImpl.cpp b/Source/WebKit/chromium/src/WebPluginScrollbarImpl.cpp

index 0085db491e8f676fcae75ea19bbfbdc5f0d24fa6..514755d2f5a3c46d87683a0b9899198f8737be3a 100644

--- a/Source/WebKit/chromium/src/WebPluginScrollbarImpl.cpp

+++ b/Source/WebKit/chromium/src/WebPluginScrollbarImpl.cpp

@@ -202,8 +202,6 @@ void WebPluginScrollbarImpl::setLocation(const WebRect& rect)

m_scrollbar->invalidate();

int length = m_scrollbar->orientation() == HorizontalScrollbar ? m_scrollbar->width() : m_scrollbar->height();

- int pageStep = max(max(static_cast<int>(static_cast<float>(length) * Scrollbar::minFractionToStepWhenPaging()), length - Scrollbar::maxOverlapBetweenPages()), 1);

- m_scrollbar->setSteps(Scrollbar::pixelsPerLineStep(), pageStep);

m_scrollbar->setEnabled(m_scrollbar->totalSize() > length);

m_scrollbar->setProportion(length, m_scrollbar->totalSize());

}