Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: build/landmines.py

Issue 16978002: Fix Landmines MSVS Version Checking (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Quick CR Feedback Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/landmines.py
===================================================================
--- build/landmines.py (revision 206100)
+++ build/landmines.py (working copy)
@@ -68,8 +68,7 @@
@memoize()
def gyp_msvs_version():
- val = os.environ.get('GYP_MSVS_VERSION', '')
- return int(val) if val else None
+ return os.environ.get('GYP_MSVS_VERSION', '')
@memoize()
def distributor():
@@ -154,7 +153,7 @@
if platform() == 'mac':
add('Switching from bundle to unbundled dylib (issue 14743002).')
if (platform() == 'win' and builder() == 'ninja' and
- gyp_msvs_version() == 2012 and
+ gyp_msvs_version() == '2012' and
scottmg 2013/06/13 18:28:57 this should be gyp_msvs_version() in ('2012', '201
robliao 2013/06/13 19:37:49 Propagating iannucci's comment: Could be, but we r
gyp_defines().get('target_arch') == 'x64' and
gyp_defines().get('dcheck_always_on') == '1'):
add("Switched win x64 trybots from VS2010 to VS2012.")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698