Chromium Code Reviews| Index: build/landmines.py |
| =================================================================== |
| --- build/landmines.py (revision 206100) |
| +++ build/landmines.py (working copy) |
| @@ -68,8 +68,7 @@ |
| @memoize() |
| def gyp_msvs_version(): |
| - val = os.environ.get('GYP_MSVS_VERSION', '') |
| - return int(val) if val else None |
| + return os.environ.get('GYP_MSVS_VERSION', '') |
| @memoize() |
| def distributor(): |
| @@ -154,7 +153,7 @@ |
| if platform() == 'mac': |
| add('Switching from bundle to unbundled dylib (issue 14743002).') |
| if (platform() == 'win' and builder() == 'ninja' and |
| - gyp_msvs_version() == 2012 and |
| + gyp_msvs_version() == '2012' and |
|
scottmg
2013/06/13 18:28:57
this should be gyp_msvs_version() in ('2012', '201
robliao
2013/06/13 19:37:49
Propagating iannucci's comment: Could be, but we r
|
| gyp_defines().get('target_arch') == 'x64' and |
| gyp_defines().get('dcheck_always_on') == '1'): |
| add("Switched win x64 trybots from VS2010 to VS2012.") |