Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16975019: Remove XML FROM element in JingleSession::StartConnection (Closed)

Created:
7 years, 6 months ago by solb
Modified:
7 years, 6 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove XML FROM element in JingleSession::StartConnection This element caused an assertion failure in libjingle at xmpp/xmppengineimpl.cc:367 when used from the client-side code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207814

Patch Set 1 #

Patch Set 2 : Reinvented fix to repair broken unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M remoting/protocol/jingle_messages.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M remoting/protocol/jingle_session.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
solb
Could we confirm that this doesn't break the client code? (Otherwise, we can exclude it ...
7 years, 6 months ago (2013-06-19 22:47:16 UTC) #1
Sergey Ulanov
LGTM. Please remove BUG= from the description. On 2013/06/19 22:47:16, solb wrote: > Could we ...
7 years, 6 months ago (2013-06-19 22:49:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/solb@chromium.org/16975019/1
7 years, 6 months ago (2013-06-20 01:47:42 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=140498
7 years, 6 months ago (2013-06-20 03:49:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/solb@chromium.org/16975019/1
7 years, 6 months ago (2013-06-20 17:16:15 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=140912
7 years, 6 months ago (2013-06-20 18:18:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/solb@chromium.org/16975019/23002
7 years, 6 months ago (2013-06-20 22:05:43 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 14:40:42 UTC) #8
Message was sent while issue was closed. 
Change committed as 207814

Powered by Google App Engine
This is Rietveld 408576698