Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6466)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/document_ready/embedder.js

Issue 16975007: Run shim's watchForTag on document.DOMContentLoaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from kalman@ Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/extensions/web_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/platform_apps/web_view/document_ready/embedder.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/document_ready/embedder.js b/chrome/test/data/extensions/platform_apps/web_view/document_ready/embedder.js
index d39217debdacd4ba4c74fc4c7671803ca6a7768e..648861ba081d3643c33c35af79f9a1fb9964e6fe 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/document_ready/embedder.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/document_ready/embedder.js
@@ -4,6 +4,19 @@
document.addEventListener('DOMContentLoaded', function(e) {
var webview = document.querySelector('webview');
+
+ // App code is not expected to redefine property on WebView.
+ var canRedefineNameProperty = true;
+ try {
+ Object.defineProperty(webview, 'name', {
+ get: function() { return 'foo'; },
+ set: function(value) {},
+ enumerable: true
+ });
+ } catch (e) {
+ canRedefineNameProperty = false;
+ }
+
webview.addEventListener('loadstop', function(e) {
// Note that we are relying on .partition property to read the partition.
// The other way would be to read this value from BrowserPluginGuest in cpp
@@ -11,12 +24,10 @@ document.addEventListener('DOMContentLoaded', function(e) {
// test).
var partitionName = webview.partition;
chrome.test.runTests([
- function checkPartition() {
- if (partitionName == 'persist:test-partition') {
- chrome.test.succeed();
- } else {
- chrome.test.fail();
- }
+ function checkRedefinePropertyAndPartitionCorrectness() {
+ chrome.test.assertFalse(canRedefineNameProperty);
+ chrome.test.assertEq('persist:test-partition', partitionName);
+ chrome.test.succeed();
}
]);
});
« no previous file with comments | « chrome/renderer/resources/extensions/web_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698