Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6770)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 16975007: Run shim's watchForTag on document.DOMContentLoaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + add test code from @kalman's comment Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 1651fff3b20b3607cb7c21e33891ea55e9bfdfa6..a3ad079fd88bf3a103651559316c5d314e17f495 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -7,6 +7,8 @@
// The actual tag is implemented via the browser plugin. The internals of this
// are hidden via Shadow DOM.
+var renderViewObserverNatives = requireNative('renderViewObserverNatives');
+
var watchForTag = require('tagWatcher').watchForTag;
/** @type {Array.<string>} */
@@ -43,8 +45,23 @@ var WEB_VIEW_EVENTS = {
'unresponsive' : ['processId']
};
-window.addEventListener('DOMContentLoaded', function() {
- watchForTag('WEBVIEW', function(addedNode) { new WebView(addedNode); });
+var documentA = document;
+renderViewObserverNatives.OnDocumentCreatedForCurrentContext(function() {
+ var documentB = document;
+ window.console.log('old document: ' + documentA);
+ window.console.log('new document: ' + documentB);
+ if (documentA == documentB) {
+ window.console.log('both document are equal');
+ } else {
+ window.console.log('documents are different');
+ }
+ // At this point we have a new document where app's content would go
+ // (document.readyState == 'loading'), run watchForTag() once document's
+ // OnDOMContentLoaded fires.
+ document.addEventListener('DOMContentLoaded', function(e) {
+ window.console.log('shim: document.DOMContentLoaded');
+ watchForTag('WEBVIEW', function(addedNode) { new WebView(addedNode); });
+ });
});
/**

Powered by Google App Engine
This is Rietveld 408576698