Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1985)

Unified Diff: chrome/renderer/extensions/chrome_v8_context.cc

Issue 16975007: Run shim's watchForTag on document.DOMContentLoaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + add test code from @kalman's comment Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/app_window_custom_bindings.cc ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/chrome_v8_context.cc
diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc
index 79a03dcb64dc6198b664d18906b8db97425f2f8f..e8e18ec8155cf2e9e986e9780f4a4e4d1cbb9931 100644
--- a/chrome/renderer/extensions/chrome_v8_context.cc
+++ b/chrome/renderer/extensions/chrome_v8_context.cc
@@ -77,6 +77,8 @@ v8::Local<v8::Value> ChromeV8Context::CallFunction(
int argc,
v8::Handle<v8::Value> argv[]) const {
v8::HandleScope handle_scope;
+ v8::Context::Scope scope(v8_context());
lazyboy 2013/06/18 23:49:16 @kalman, did you mean here? How can I (or do I nee
not at google - send to devlin 2013/06/18 23:51:14 Yep, thanks.
+
WebKit::WebScopedMicrotaskSuppression suppression;
if (!is_valid())
return handle_scope.Close(v8::Undefined());
« no previous file with comments | « chrome/renderer/extensions/app_window_custom_bindings.cc ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698