Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4802)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 16975007: Run shim's watchForTag on document.DOMContentLoaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from kalman@ Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/extensions/app_window_custom_bindings.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 1a210ab96808ca0fd140316c3525b979c619112a..ae3547c828731a74bdaaf248b1cd508be1b59a7c 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -7,6 +7,8 @@
// The actual tag is implemented via the browser plugin. The internals of this
// are hidden via Shadow DOM.
+var renderViewObserverNatives = requireNative('renderViewObserverNatives');
+
var forEach = require('utils').forEach;
var watchForTag = require('tagWatcher').watchForTag;
@@ -44,8 +46,21 @@ var WEB_VIEW_EVENTS = {
'unresponsive' : ['processId']
};
-window.addEventListener('DOMContentLoaded', function() {
- watchForTag('WEBVIEW', function(addedNode) { new WebView(addedNode); });
+var documentA = document;
+renderViewObserverNatives.OnDocumentCreatedForCurrentContext(function() {
+ var documentB = document;
+ if (documentA == documentB) {
adamk 2013/06/18 22:26:49 This only makes sense to me if documentA is undefi
lazyboy 2013/06/18 22:54:47 Surprisingly it is not, I tried to addEventListene
+ window.console.log('both document are equal');
+ } else {
+ window.console.log('documents are different');
+ }
+ // At this point we have a new document where app's content would go
+ // (document.readyState == 'loading'), run watchForTag() once document's
+ // OnDOMContentLoaded fires.
+ document.addEventListener('DOMContentLoaded', function(e) {
+ window.console.log('shim: document.DOMContentLoaded');
+ watchForTag('WEBVIEW', function(addedNode) { new WebView(addedNode); });
+ });
});
/**
« no previous file with comments | « chrome/renderer/resources/extensions/app_window_custom_bindings.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698