Try convert polymorphic stores into a single monomorphic store.

Try convert polymorphic stores into a single monomorphic store.

R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15158

[Toon Verwaest, 2013-06-13 20:05:44]

New version of https://codereview.chromium.org/14796012/. PTAL.

[Jakob Kummerow, 2013-06-14 13:08:05]

LGTM with comments.

https://chromiumcodereview.appspot.com/16975006/diff/5001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/16975006/diff/5001/src/hydrogen.cc#new...
src/hydrogen.cc:6365: bool
HOptimizedGraphBuilder::TryStorePolymorphicAsMonomorphic(
This method looks very similar to TryLoadPolymorphicAsMonomorphic. Can you unify
them into a generic parameterized version, or extract the common stuff into a
shared helper?

It's fine to do that in a separate CL; landing the functional change first and
doing the cleanup later makes sense. In that case, I'd advocate a TODO comment
with your name on it ;-)

https://chromiumcodereview.appspot.com/16975006/diff/5001/src/hydrogen.cc#new...
src/hydrogen.cc:6416: AddSimulate(expr->AssignmentId(), REMOVABLE_SIMULATE);
For the record, I think it's pointless (but safe) to mark this simulate as
removable. Stores always have a side effect, and simulates after side effects
can never be removed. So feel free to remove the REMOVABLE_SIMULATE parameter.

[Toon Verwaest, 2013-06-14 13:15:04]

Addressed comments

[Toon Verwaest, 2013-06-14 14:16:09]

Committed patchset #3 manually as r15158 (presubmit successful).