Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: Source/bindings/scripts/compute_interfaces_info.py

Issue 169743005: Faster run-bindings-tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Another merge Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/compute_interfaces_info.py
diff --git a/Source/bindings/scripts/compute_interfaces_info.py b/Source/bindings/scripts/compute_interfaces_info.py
index d0516d97c25fb83dbcaf3410f18e5229f10d7c75..7b8c73d55c7c02258cb6215b00c283a563ee8075 100755
--- a/Source/bindings/scripts/compute_interfaces_info.py
+++ b/Source/bindings/scripts/compute_interfaces_info.py
@@ -346,6 +346,23 @@ def compute_interfaces_info(idl_files):
implemented_interfaces_include_paths)
+def clear_globals():
+ interfaces_info.clear()
+ partial_interface_files.clear()
+ parent_interfaces.clear()
+ extended_attributes_by_interface.clear() # interface name -> extended attributes
Nils Barth (inactive) 2014/03/03 01:32:48 Could you remove the comment at the end of the lin
terry 2014/03/13 19:58:18 Done.
+
+
+def compute(idl_files, interfaces_info_file, interface_dependencies_file,
Nils Barth (inactive) 2014/03/03 06:45:49 This function (and clear_globals()) won't be neces
+ event_names_file, only_if_changed):
+ clear_globals()
+
Nils Barth (inactive) 2014/03/03 01:32:48 Could you remove this blank line, as the function
terry 2014/03/13 19:58:18 Done.
+ compute_interfaces_info(idl_files)
+ write_pickle_file(interfaces_info_file, interfaces_info, only_if_changed)
+ write_dependencies_file(interface_dependencies_file, only_if_changed)
Nils Barth (inactive) 2014/03/03 01:32:48 BTW, I'm removing the interface_dependencies_file
terry 2014/03/13 19:58:18 Done.
+ write_event_names_file(event_names_file, only_if_changed)
+
+
################################################################################
def main():
@@ -360,11 +377,11 @@ def main():
# cannot be included in the file listing static files
idl_files.extend(args)
- only_if_changed = options.write_file_only_if_changed
- compute_interfaces_info(idl_files)
- write_pickle_file(options.interfaces_info_file, interfaces_info, only_if_changed)
- write_dependencies_file(options.interface_dependencies_file, only_if_changed)
- write_event_names_file(options.event_names_file, only_if_changed)
+ compute(idl_files,
+ options.interfaces_info_file,
+ options.interface_dependencies_file,
+ options.event_names_file,
+ options.write_file_only_if_changed)
if __name__ == '__main__':

Powered by Google App Engine
This is Rietveld 408576698