Faster run-bindings-tests

Source/bindings/scripts/unstable/idl_compiler.py

 #!/usr/bin/python
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 
 FIXME: Not currently used in build.
 This is a rewrite of the Perl IDL compiler in Python, but is not complete.
 Once it is complete, we will switch all IDL files over to Python at once.
 Until then, please work on the Perl IDL compiler.
 For details, see bug http://crbug.com/239771
 """
 
 import optparse
 import os
-import cPickle as pickle
 import sys
 
 import code_generator_v8
 import idl_reader
 
 def parse_options():
     parser = optparse.OptionParser()
     parser.add_option('--idl-attributes-file')
     parser.add_option('--output-directory')
-    parser.add_option('--interfaces-info-file')
     parser.add_option('--write-file-only-if-changed', type='int')
     # ensure output comes last, so command line easy to parse via regexes
     parser.disable_interspersed_args()
 
     options, args = parser.parse_args()
     if options.output_directory is None:
         parser.error('Must specify output directory using --output-directory.')
     if len(args) != 1:
         parser.error('Must specify exactly 1 input file as argument, but %d given.' % len(args))
     idl_filename = os.path.realpath(args[0])
     return options, idl_filename
 
 
+def compile_idl(idl_filename, output_directory, idl_attributes_file,
+                curr_interfaces_info={}, reader=None,
+                write_header_and_cpp=code_generator_v8.write_header_and_cpp):

[Nils Barth (inactive), 2014/02/25 07:29:59]

I ultimately decided that a code generator object is a good idea
for other reasons too (for initialization, say, which should speed
it up further); hope this makes it easier!

We could standardize the method name if that makes it clearer,
or more precisely have an abstract base class (CodeGenerator)
and then implement the generate_code() or compile() method in
derived classes.

CL is:
Use a class for CodeGeneratorV8
https://codereview.chromium.org/179423002/

[terry, 2014/02/27 23:40:26]

This works for me right now.  Maybe an abstract case would be nicer but this is
fine for now.

On 2014/02/25 07:29:59, Nils Barth wrote:

+    basename = os.path.basename(idl_filename)
+    interface_name, _ = os.path.splitext(basename)
+    output_directory = output_directory
+
+    interfaces_info = curr_interfaces_info
+
+    if reader == None:
+        reader = idl_reader.IdlReader(interfaces_info, idl_attributes_file, output_directory)
+    definitions = reader.read_idl_definitions(idl_filename)
+    write_header_and_cpp(definitions, interface_name, interfaces_info, output_directory)
+
+    return reader
+
+
 def main():
     options, idl_filename = parse_options()
-    basename = os.path.basename(idl_filename)
-    interface_name, _ = os.path.splitext(basename)
-    output_directory = options.output_directory
-
-    interfaces_info_filename = options.interfaces_info_file
-    if interfaces_info_filename:
-        with open(interfaces_info_filename) as interfaces_info_file:
-            interfaces_info = pickle.load(interfaces_info_file)
-    else:
-        interfaces_info = None
-
-    reader = idl_reader.IdlReader(interfaces_info, options.idl_attributes_file, output_directory)
-    definitions = reader.read_idl_definitions(idl_filename)
-    code_generator_v8.write_header_and_cpp(definitions, interface_name, interfaces_info, output_directory)
-
+    compile_idl(idl_filename, options.output_directory, options.idl_attributes_file)
 
 if __name__ == '__main__':
     sys.exit(main())