Fix test case table in HistoryURLProviderTest for C++11

Fix test case table in HistoryURLProviderTest for C++11

C++11 narrowing rules do not accept converting signed literals (-1) to
unsigned types (size_t), so the table for SuggestExactInput test breaks
compilation when using G++ 4.7.2.
    
This patch uses a localized version of std::string::npos instead of the
literal -1.

BUG=237284
TEST=unit_tests --gtest_filter="*SuggestExactInput"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206854

[cmarcelo, 2013-06-16 22:04:31]

pkasting, could you take a look at this?

[Peter Kasting, 2013-06-17 18:43:43]

https://codereview.chromium.org/16972007/diff/1/chrome/browser/autocomplete/h...
File chrome/browser/autocomplete/history_url_provider_unittest.cc (right):

https://codereview.chromium.org/16972007/diff/1/chrome/browser/autocomplete/h...
chrome/browser/autocomplete/history_url_provider_unittest.cc:803: ssize_t
offsets[3];
Do not use ssize_t, use size_t.  To avoid having to static_cast everywhere
below, declare a constant of type size_t and value -1 and use that in the
various initializers.

[cmarcelo, 2013-06-17 18:48:52]

https://codereview.chromium.org/16972007/diff/1/chrome/browser/autocomplete/h...
File chrome/browser/autocomplete/history_url_provider_unittest.cc (right):

https://codereview.chromium.org/16972007/diff/1/chrome/browser/autocomplete/h...
chrome/browser/autocomplete/history_url_provider_unittest.cc:803: ssize_t
offsets[3];
On 2013/06/17 18:43:43, Peter Kasting wrote:
> Do not use ssize_t, use size_t.  To avoid having to static_cast everywhere
> below, declare a constant of type size_t and value -1 and use that in the
> various initializers.

Would be OK to (re-)use std::string::npos?

[Peter Kasting, 2013-06-17 18:53:12]

https://codereview.chromium.org/16972007/diff/1/chrome/browser/autocomplete/h...
File chrome/browser/autocomplete/history_url_provider_unittest.cc (right):

https://codereview.chromium.org/16972007/diff/1/chrome/browser/autocomplete/h...
chrome/browser/autocomplete/history_url_provider_unittest.cc:803: ssize_t
offsets[3];
On 2013/06/17 18:48:52, cmarcelo wrote:
> On 2013/06/17 18:43:43, Peter Kasting wrote:
> > Do not use ssize_t, use size_t.  To avoid having to static_cast everywhere
> > below, declare a constant of type size_t and value -1 and use that in the
> > various initializers.
> 
> Would be OK to (re-)use std::string::npos?

Yes, in fact, that's what _should_ be used, since these are intended to be
offsets into strings.

Thanks for asking, I feel dumb not having realized that right away.

You could probably do "using std::string::npos" inside this function to avoid
having to paste longer qualified names everywhere.

[cmarcelo, 2013-06-17 19:55:23]

Thanks for the review, pkasting. Updated to address your comments.

I've also changed the commit message but noticed that description for the issue
didn't change. When the CQ commits, does it take the description or the commit
message from my last patch?

[Peter Kasting, 2013-06-17 20:13:11]

LGTM

I always edit the patch title and message directly on codereview.chromium.org ,
so I don't know how/whether changes made in other places will be reflected on
commit.

[commit-bot: I haz the power, 2013-06-17 20:50:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caio.de.oliveira.filho@intel.com/16972...

[commit-bot: I haz the power, 2013-06-18 00:09:31]

Change committed as 206854