Issue 16972006: Insert text directly from the virtual keyboard.

Issue 16972006: Insert text directly from the virtual keyboard. (Closed)

Created:
7 years, 6 months ago by bryeung

Modified:
7 years, 6 months ago

Reviewers:
sadrul, asargent_no_longer_on_chrome, sky

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Insert text directly from the virtual keyboard. This allows the insertion of text that does not directly correspond to key codes. The new API introduced is a temporary solution to allow us to continue prototyping the virtual keyboard and understanding how the implementation will interact with IMEs until proper IME integration can be achieved. BUG=237533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207752

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : clean some stuff up #

Total comments: 1

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : gyp fix #

Patch Set 7 : fix include #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -857 lines)			Patch
M	chrome/browser/extensions/api/input/input.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/api/input/input.cc	View	1 2 3 4 5 6	3 chunks	+6 lines, -13 lines	0 comments	Download
D	chrome/browser/extensions/api/input/input_apitest.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_histogram_value.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/experimental_input_virtual_keyboard.json	View	1 2	1 chunk	+6 lines, -36 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/input/manifest.json	View		1 chunk	+0 lines, -10 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/input/test.js	View		1 chunk	+0 lines, -116 lines	0 comments	Download
D	ui/base/events/key_identifier_conversion.h	View		1 chunk	+0 lines, -25 lines	0 comments	Download
D	ui/base/events/key_identifier_conversion.cc	View	1 2 3	1 chunk	+0 lines, -343 lines	0 comments	Download
D	ui/base/events/key_identifier_conversion_unittest.cc	View		1 chunk	+0 lines, -63 lines	0 comments	Download
M	ui/keyboard/keyboard_ui_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/keyboard/keyboard_ui_handler.cc	View		2 chunks	+15 lines, -11 lines	0 comments	Download
M	ui/keyboard/keyboard_util.h	View	1 2 3	2 chunks	+9 lines, -14 lines	0 comments	Download
M	ui/keyboard/keyboard_util.cc	View	1 2 3	2 chunks	+37 lines, -114 lines	0 comments	Download
M	ui/keyboard/resources/api_adapter.js	View	1 2	1 chunk	+2 lines, -7 lines	0 comments	Download
M	ui/keyboard/resources/elements/kb-keyboard.html	View	1 2	3 chunks	+4 lines, -11 lines	0 comments	Download
M	ui/keyboard/resources/keysets.html	View	1 2	8 chunks	+18 lines, -18 lines	0 comments	Download
M	ui/keyboard/resources/main.js	View	1 2	1 chunk	+0 lines, -18 lines	0 comments	Download
M	ui/keyboard/resources/voice_input.js	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/keyboard/resources/webui/api_adapter.js	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download
M	ui/keyboard/resources/webui/keysets.html	View	1 2	7 chunks	+18 lines, -18 lines	0 comments	Download
M	ui/ui.gyp	View	1 2 3 4	2 chunks	+0 lines, -4 lines	0 comments	Download
M	ui/ui_unittests.gypi	View	1 2 3 4	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

bryeung

sadrul: for ui/keyboard asargent: for extensions sky: for the rest of ui/ Please and thanks.

7 years, 6 months ago (2013-06-14 18:02:46 UTC) #1

asargent_no_longer_on_chrome

extensions parts LGTM https://codereview.chromium.org/16972006/diff/5001/chrome/common/extensions/api/experimental_input_virtual_keyboard.json File chrome/common/extensions/api/experimental_input_virtual_keyboard.json (right): https://codereview.chromium.org/16972006/diff/5001/chrome/common/extensions/api/experimental_input_virtual_keyboard.json#newcode7 chrome/common/extensions/api/experimental_input_virtual_keyboard.json:7: "namespace": "experimental.input.virtualKeyboard", Not necessary for this ...

7 years, 6 months ago (2013-06-17 17:54:58 UTC) #3