chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java - Issue 1696963002: Move SharedPreference for download into DownloadNotificationService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

Issue 1696963002: Move SharedPreference for download into DownloadNotificationService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

index f13c97eccdc8925b72e6cc8c1c5836e0819cd9da..354b65669c379b898297aa347112b1e76dbb97b2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

@@ -35,7 +35,7 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr

Pair<DownloadInfo, Long> download = (Pair<DownloadInfo, Long>) actionData;

DownloadManagerService manager = DownloadManagerService.getDownloadManagerService(mContext);

manager.openDownloadedContent(download.second);

- manager.removeProgressNotificationForDownload(download.first.getDownloadId());

+ manager.cancelNotification(download.first.getDownloadId());

}

@Override