Issue 16968003: Rewrite scoped_ptr<T>(NULL) to use the default ctor in ash/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16968003: Rewrite scoped_ptr<T>(NULL) to use the default ctor in ash/. (Closed)

Created:
7 years, 6 months ago by dcheng

Modified:
7 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Rewrite scoped_ptr<T>(NULL) to use the default ctor in ash/. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on CrOS in the ash/ directory. BUG=173286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206125

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -28 lines)			Patch
M	ash/display/screen_position_controller_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/drag_drop/drag_drop_controller.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/root_window_controller.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/shelf/shelf_widget.cc	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	ash/wm/drag_window_resizer_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/frame_painter.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ash/wm/gestures/long_press_affordance_handler.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ash/wm/workspace/workspace_cycler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/wm/workspace/workspace_cycler_animator.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16968003/1

7 years, 6 months ago (2013-06-13 15:41:36 UTC) #3

Message was sent while issue was closed.

Change committed as 206125