Rewrite scoped_ptr<T>(NULL) to use the default ctor in chromeos/.

Rewrite scoped_ptr<T>(NULL) to use the default ctor in chromeos/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on CrOS in the chromeos/ directory.

BUG=173286
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206241

[Daniel Erat, 2013-06-13 15:46:33]

lgtm

https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
File chromeos/dbus/debug_daemon_client.cc (right):

https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
chromeos/dbus/debug_daemon_client.cc:144: : debugdaemon_proxy_(NULL),
weak_ptr_factory_(this) {
nit: i believe that these should remain on separate lines since they don't fit
on the same line as the c'tor's signature

[dcheng, 2013-06-13 15:48:11]

https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
File chromeos/dbus/debug_daemon_client.cc (right):

https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
chromeos/dbus/debug_daemon_client.cc:144: : debugdaemon_proxy_(NULL),
weak_ptr_factory_(this) {
On 2013/06/13 15:46:33, Daniel Erat wrote:
> nit: i believe that these should remain on separate lines since they don't fit
> on the same line as the c'tor's signature

This is the result from clang-format-diff. If you prefer, I can manually revert
this.

[Daniel Erat, 2013-06-13 15:49:44]

https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
File chromeos/dbus/debug_daemon_client.cc (right):

https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
chromeos/dbus/debug_daemon_client.cc:144: : debugdaemon_proxy_(NULL),
weak_ptr_factory_(this) {
On 2013/06/13 15:48:11, dcheng wrote:
> On 2013/06/13 15:46:33, Daniel Erat wrote:
> > nit: i believe that these should remain on separate lines since they don't
fit
> > on the same line as the c'tor's signature
> 
> This is the result from clang-format-diff. If you prefer, I can manually
revert
> this.

thanks, please do so. i think that clang-format-diff conflicts with the style
guide here -- see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...

[dcheng, 2013-06-13 18:49:20]

https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
File chromeos/dbus/debug_daemon_client.cc (right):

https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
chromeos/dbus/debug_daemon_client.cc:144: : debugdaemon_proxy_(NULL),
weak_ptr_factory_(this) {
On 2013/06/13 15:49:44, Daniel Erat wrote:
> On 2013/06/13 15:48:11, dcheng wrote:
> > On 2013/06/13 15:46:33, Daniel Erat wrote:
> > > nit: i believe that these should remain on separate lines since they don't
> fit
> > > on the same line as the c'tor's signature
> > 
> > This is the result from clang-format-diff. If you prefer, I can manually
> revert
> > this.
> 
> thanks, please do so. i think that clang-format-diff conflicts with the style
> guide here -- see
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...

Done.

However, a literal reading suggests that this is, in fact, permissible.
"Constructor initializer lists can be all on one line"
DebugDaemonClientImpl(dbus::Bus* bus) is not part of the initializer list, thus
the initializer list is still on one line.

Indirectly, further support for this can be found in
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...;
there, it explicitly states that parameters should be on the same line if they
fit.

[commit-bot: I haz the power, 2013-06-13 19:31:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/16966003/4001

[Daniel Erat, 2013-06-13 20:29:01]

On 2013/06/13 18:49:20, dcheng wrote:
>
https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
> File chromeos/dbus/debug_daemon_client.cc (right):
> 
>
https://codereview.chromium.org/16966003/diff/1/chromeos/dbus/debug_daemon_cl...
> chromeos/dbus/debug_daemon_client.cc:144: : debugdaemon_proxy_(NULL),
> weak_ptr_factory_(this) {
> On 2013/06/13 15:49:44, Daniel Erat wrote:
> > On 2013/06/13 15:48:11, dcheng wrote:
> > > On 2013/06/13 15:46:33, Daniel Erat wrote:
> > > > nit: i believe that these should remain on separate lines since they
don't
> > fit
> > > > on the same line as the c'tor's signature
> > > 
> > > This is the result from clang-format-diff. If you prefer, I can manually
> > revert
> > > this.
> > 
> > thanks, please do so. i think that clang-format-diff conflicts with the
style
> > guide here -- see
> >
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...
> 
> Done.
> 
> However, a literal reading suggests that this is, in fact, permissible.
> "Constructor initializer lists can be all on one line"
> DebugDaemonClientImpl(dbus::Bus* bus) is not part of the initializer list,
thus
> the initializer list is still on one line.
> 
> Indirectly, further support for this can be found in
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...;
> there, it explicitly states that parameters should be on the same line if they
> fit.

Hmm. I'm pretty sure that I've seen Chromium review comments stating that the
same "all on the same line as the method name if they fit; each on its own line
otherwise" guideline applies to function declarations too (e.g. in the second
example at
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...,
par_name2 should be on its own line), but I agree that this doesn't appear to be
forbidden in the Google style guide. I also see code in Chromium that does this,
so perhaps it's okay after all. See base/threading/simple_thread.cc, for
example:

SimpleThread::SimpleThread(const std::string& name_prefix,
                           const Options& options)
    : name_prefix_(name_prefix), name_(name_prefix), options_(options),
      thread_(), event_(true, false), tid_(0), joined_(false) {
}

[commit-bot: I haz the power, 2013-06-14 00:23:01]

Change committed as 206241