Rewrite scoped_ptr<T>(NULL) to use the default ctor in components/.

Rewrite scoped_ptr<T>(NULL) to use the default ctor in components/.

This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on Linux in the components/ directory.

BUG=173286
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206117

[Jói, 2013-06-13 14:48:55]

LGTM

On Thu, Jun 13, 2013 at 2:46 PM,  <dcheng@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Rewrite scoped_ptr<T>(NULL) to use the default ctor in components/.
>
> This is the result of running the rewrite_scoped_ptr_ctor_null tool
> across all files built on Linux in the components/ directory.
>
> BUG=173286
>
> Please review this at https://codereview.chromium.org/16966002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M components/autofill/browser/autofill_manager.cc
>   M components/autofill/browser/phone_number_i18n.cc
>   M
>
components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc
>   M components/webdata/common/web_data_request_manager.cc
>   M components/webdata/common/web_data_service_backend.cc
>
>
> Index: components/autofill/browser/autofill_manager.cc
> diff --git a/components/autofill/browser/autofill_manager.cc
> b/components/autofill/browser/autofill_manager.cc
> index
>
e7b2171746ce9158104609e205bb0d90653e458a..666974fb308c35d52b1499b07bc338bdcba5acf6
> 100644
> --- a/components/autofill/browser/autofill_manager.cc
> +++ b/components/autofill/browser/autofill_manager.cc
> @@ -1236,7 +1236,7 @@ void AutofillManager::ParseForms(const
> std::vector<FormData>& forms) {
>      // no form in the page. This give |autocheckout_manager| a chance to
>      // terminate Autocheckout and send Autocheckout status.
>      autocheckout_manager_.OnLoadedPageMetaData(
> -        scoped_ptr<autofill::AutocheckoutPageMetaData>(NULL));
> +        scoped_ptr<autofill::AutocheckoutPageMetaData>());
>    } else if (download_manager_) {
>      // Query the server if we have at least one of the forms were parsed.
>      download_manager_->StartQueryRequest(form_structures_.get(),
> Index: components/autofill/browser/phone_number_i18n.cc
> diff --git a/components/autofill/browser/phone_number_i18n.cc
> b/components/autofill/browser/phone_number_i18n.cc
> index
>
17a13481d4a4da1448352b270e46330e7affd803..d8ad08eb0e0fc5dc7b2fee1e6470105a7f0289de
> 100644
> --- a/components/autofill/browser/phone_number_i18n.cc
> +++ b/components/autofill/browser/phone_number_i18n.cc
> @@ -228,8 +228,7 @@ bool PhoneNumbersMatch(const base::string16& number_a,
>
>  PhoneObject::PhoneObject(const base::string16& number,
>                           const std::string& region)
> -    : region_(region),
> -      i18n_number_(NULL) {
> +    : region_(region) {
>    DCHECK_EQ(2u, region.size());
>    // TODO(isherman): Autofill profiles should always have a |region| set,
> but in
>    // some cases it should be marked as implicit.  Otherwise, phone numbers
> @@ -250,12 +249,9 @@ PhoneObject::PhoneObject(const base::string16& number,
>    }
>  }
>
> -PhoneObject::PhoneObject(const PhoneObject& other) : i18n_number_(NULL) {
> -  *this = other;
> -}
> +PhoneObject::PhoneObject(const PhoneObject& other) { *this = other; }
>
> -PhoneObject::PhoneObject() : i18n_number_(NULL) {
> -}
> +PhoneObject::PhoneObject() {}
>
>  PhoneObject::~PhoneObject() {
>  }
> Index:
>
components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc
> diff --git
>
a/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc
>
b/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc
> index
>
0db3ddac0414548942d4fd4836d28e570b3982b9..6082e0f69de68b5c06d3b4a872a90c6965b82671
> 100644
> ---
>
a/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc
> +++
>
b/components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc
> @@ -104,12 +104,13 @@ class MockResourceController : public
> content::ResourceController {
>
>  class TestIOThreadState {
>   public:
> -  TestIOThreadState(const GURL& url, int render_process_id, int
> render_view_id,
> +  TestIOThreadState(const GURL& url,
> +                    int render_process_id,
> +                    int render_view_id,
>                      const std::string& request_method,
>                      MockInterceptCallbackReceiver* callback_receiver)
> -      : request_(url, NULL, resource_context_.GetRequestContext()),
> -        throttle_(NULL) {
> -
> DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
> +      : request_(url, NULL, resource_context_.GetRequestContext()) {
> +
> DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
>        if (render_process_id != MSG_ROUTING_NONE &&
>            render_view_id != MSG_ROUTING_NONE) {
>          content::ResourceRequestInfo::AllocateForTesting(
> Index: components/webdata/common/web_data_request_manager.cc
> diff --git a/components/webdata/common/web_data_request_manager.cc
> b/components/webdata/common/web_data_request_manager.cc
> index
>
635e1fc05e604a3198240325e027506f2de12131..9ea1ad8456c07e0801196b017b07ae71686d9857
> 100644
> --- a/components/webdata/common/web_data_request_manager.cc
> +++ b/components/webdata/common/web_data_request_manager.cc
> @@ -16,10 +16,7 @@
>
>  WebDataRequest::WebDataRequest(WebDataServiceConsumer* consumer,
>                                 WebDataRequestManager* manager)
> -    : manager_(manager),
> -      cancelled_(false),
> -      consumer_(consumer),
> -      result_(NULL) {
> +    : manager_(manager), cancelled_(false), consumer_(consumer) {
>    handle_ = manager_->GetNextRequestHandle();
>    message_loop_ = base::MessageLoop::current();
>    manager_->RegisterRequest(this);
> Index: components/webdata/common/web_data_service_backend.cc
> diff --git a/components/webdata/common/web_data_service_backend.cc
> b/components/webdata/common/web_data_service_backend.cc
> index
>
300b182bc84e856f02c857cce1428737585640cb..321ff53e3cac089cee1732a366675f91089d30d5
> 100644
> --- a/components/webdata/common/web_data_service_backend.cc
> +++ b/components/webdata/common/web_data_service_backend.cc
> @@ -106,7 +106,7 @@ scoped_ptr<WDTypedResult>
> WebDataServiceBackend::ExecuteReadTask(
>    if (db_ && init_status_ == sql::INIT_OK) {
>      return task.Run(db_.get());
>    }
> -  return scoped_ptr<WDTypedResult>(NULL);
> +  return scoped_ptr<WDTypedResult>();
>  }
>
>  WebDataServiceBackend::~WebDataServiceBackend() {
>
>

[commit-bot: I haz the power, 2013-06-13 14:51:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/16966002/1

[commit-bot: I haz the power, 2013-06-13 18:05:13]

Change committed as 206117