Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 16963007: Remove acknowledge timeout for TouchEnd and TouchCancel events (Closed)

Created:
7 years, 6 months ago by trchen
Modified:
7 years, 6 months ago
Reviewers:
Ted C, Xianzhu
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Yusuf, Xianzhu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove acknowledge timeout for TouchEnd and TouchCancel events Waiting acknowledge for TouchEnd and TouchCancel shouldn't affect responsiveness for scroll and pinch gestures. If we timeout TouchEnd events, it can end up being processed by both user JavaScript and gesture detector, causing double handling. BUG=248090 R=tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
trchen
Hey Ted, Could you take a look and do you know who should be added ...
7 years, 6 months ago (2013-06-21 02:31:59 UTC) #1
Xianzhu
lgtm
7 years, 6 months ago (2013-06-21 16:54:53 UTC) #2
Ted C
lgtm but Xianzhu's lgtm is better than mine :-)
7 years, 6 months ago (2013-06-21 17:45:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/16963007/1
7 years, 6 months ago (2013-06-21 20:33:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/16963007/1
7 years, 6 months ago (2013-06-22 02:33:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/16963007/1
7 years, 6 months ago (2013-06-22 03:01:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/16963007/1
7 years, 6 months ago (2013-06-22 03:30:57 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 16:48:46 UTC) #8
Message was sent while issue was closed.
Change committed as 208063

Powered by Google App Engine
This is Rietveld 408576698