Issue 16962002: [css-device-adapt] insertRule tests and ASSERT for device lengths.

Issue 16962002: [css-device-adapt] insertRule tests and ASSERT for device lengths. (Closed)

Created:
7 years, 6 months ago by rune

Modified:
7 years, 6 months ago

Reviewers:
apavlov, kenneth.r.christiansen

CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[css-device-adapt] insertRule tests and ASSERT for device lengths. Added tests to make sure @viewport rules are cascaded correctly when rules are inserted before or after existing rules. ASSERTs: device-width and device-height were removed as valid <viewport-length> values. That means we should not see ValueDeviceHeight or ValueDeviceWidth while resolving ViewportArguments::CSSDeviceAdaptation. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152445

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -37 lines)			Patch
A	LayoutTests/css3/device-adapt/viewport-insert-rule-after.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	LayoutTests/css3/device-adapt/viewport-insert-rule-after-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	LayoutTests/css3/device-adapt/viewport-insert-rule-before.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A +	LayoutTests/css3/device-adapt/viewport-insert-rule-before-expected.txt	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/dom/ViewportArguments.cpp	View	1 chunk	+9 lines, -34 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/16962002/1

7 years, 6 months ago (2013-06-14 08:33:37 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=12726

7 years, 6 months ago (2013-06-14 09:23:50 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/16962002/1

7 years, 6 months ago (2013-06-14 12:34:49 UTC) #6

Message was sent while issue was closed.

Change committed as 152445

Expand Messages | Collapse Messages