Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 16959023: Move plugin registry to after flag to switch conversion (Closed)

Created:
7 years, 6 months ago by sehr
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move plugin registry to after flag to switch conversion This allows the "Portable Native Client" flag to work correctly. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3440 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M content/browser/browser_main_loop.cc View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sehr
After the excellent pointer from Darin, this is my attempt. PTAL.
7 years, 6 months ago (2013-06-20 18:40:33 UTC) #1
darin (slow to review)
LGTM, but I'd like jam's review too.
7 years, 6 months ago (2013-06-20 19:25:18 UTC) #2
jam
lgtm
7 years, 6 months ago (2013-06-20 19:51:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sehr@chromium.org/16959023/1
7 years, 6 months ago (2013-06-20 19:58:49 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 06:51:55 UTC) #5
Message was sent while issue was closed.
Change committed as 207736

Powered by Google App Engine
This is Rietveld 408576698