filter/dscache/ds_txn_state.go - Issue 1695833002: dscache: Only log unusual memcache errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: filter/dscache/ds_txn_state.go

Issue 1695833002: dscache: Only log unusual memcache errors. (Closed) Base URL: https://github.com/luci/gae@master

Patch Set: Rewrite with errors.Filter Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: filter/dscache/ds_txn_state.go

diff --git a/filter/dscache/ds_txn_state.go b/filter/dscache/ds_txn_state.go

index 4497fcb99aa04720c4ece8d6f9eb56f01287b9c4..40019bf3ee34c8a3fa467590ef3a04c2d9a06626 100644

--- a/filter/dscache/ds_txn_state.go

+++ b/filter/dscache/ds_txn_state.go

@@ -60,8 +60,7 @@ func (s *dsTxnState) release(sc *supportContext) {

delKeys = append(delKeys, k)

}

- err := sc.mc.DeleteMulti(delKeys)

- if err != nil {

+ if err := filterMCErr(sc.mc.DeleteMulti(delKeys)); err != nil {

(log.Fields{log.ErrorKey: err}).Warningf(

sc.c, "dscache: txn.release: memcache.DeleteMulti")

}