Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 16957005: Temporarily patch HCompareIDAndBranch to accept Smi. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Temporarily patch HCompareIDAndBranch to accept Smi. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15122

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/hydrogen.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 6 months ago (2013-06-13 12:02:36 UTC) #1
Jakob Kummerow
LGTM with a comment. https://chromiumcodereview.appspot.com/16957005/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/16957005/diff/1/src/hydrogen.cc#newcode9924 src/hydrogen.cc:9924: if (left_rep.IsInteger32()) left_rep = Representation::Smi(); ...
7 years, 6 months ago (2013-06-13 13:34:41 UTC) #2
Toon Verwaest
Addressed comments.
7 years, 6 months ago (2013-06-13 14:20:52 UTC) #3
Toon Verwaest
7 years, 6 months ago (2013-06-13 14:58:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698