Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10686)

Unified Diff: chrome/browser/history/visit_database_unittest.cc

Issue 16951015: Remove TextDatabase from the history service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replace_fts
Patch Set: Sync and rebase. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/visit_database.cc ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/visit_database_unittest.cc
diff --git a/chrome/browser/history/visit_database_unittest.cc b/chrome/browser/history/visit_database_unittest.cc
index a6146b49824fe5605480bf567a0eb418639d0035..df8075e505668d99009b0ea95590f2ac45b4bbda 100644
--- a/chrome/browser/history/visit_database_unittest.cc
+++ b/chrome/browser/history/visit_database_unittest.cc
@@ -29,8 +29,7 @@ bool IsVisitInfoEqual(const VisitRow& a,
a.url_id == b.url_id &&
a.visit_time == b.visit_time &&
a.referring_visit == b.referring_visit &&
- a.transition == b.transition &&
- a.is_indexed == b.is_indexed;
+ a.transition == b.transition;
}
} // namespace
@@ -148,7 +147,6 @@ TEST_F(VisitDatabaseTest, Update) {
modification.transition = content::PAGE_TRANSITION_TYPED;
modification.visit_time = Time::Now() + TimeDelta::FromDays(1);
modification.referring_visit = 9292;
- modification.is_indexed = true;
UpdateVisitRow(modification);
// Check that the mutated version was written.
@@ -387,31 +385,4 @@ TEST_F(VisitDatabaseTest, VisitSource) {
EXPECT_EQ(SOURCE_EXTENSION, sources[matches[0].visit_id]);
}
-TEST_F(VisitDatabaseTest, GetIndexedVisits) {
- // Add non-indexed visits.
- int url_id = 111;
- VisitRow visit_info1(
- url_id, Time::Now(), 0, content::PAGE_TRANSITION_LINK, 0);
- ASSERT_TRUE(AddVisit(&visit_info1, SOURCE_BROWSED));
-
- VisitRow visit_info2(
- url_id, Time::Now(), 0, content::PAGE_TRANSITION_TYPED, 0);
- ASSERT_TRUE(AddVisit(&visit_info2, SOURCE_SYNCED));
-
- std::vector<VisitRow> visits;
- EXPECT_TRUE(GetVisitsForURL(url_id, &visits));
- EXPECT_EQ(static_cast<size_t>(2), visits.size());
- EXPECT_TRUE(GetIndexedVisitsForURL(url_id, &visits));
- EXPECT_EQ(static_cast<size_t>(0), visits.size());
-
- VisitRow visit_info3(
- url_id, Time::Now(), 2, content::PAGE_TRANSITION_TYPED, 0);
- visit_info3.is_indexed = true;
- ASSERT_TRUE(AddVisit(&visit_info3, SOURCE_SYNCED));
- EXPECT_TRUE(GetVisitsForURL(url_id, &visits));
- EXPECT_EQ(static_cast<size_t>(3), visits.size());
- EXPECT_TRUE(GetIndexedVisitsForURL(url_id, &visits));
- EXPECT_EQ(static_cast<size_t>(1), visits.size());
-}
-
} // namespace history
« no previous file with comments | « chrome/browser/history/visit_database.cc ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698