Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: Source/core/dom/Element.cpp

Issue 16951003: Fix broken AttachContext from r152289 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index 4b4c6413ee03f3893f8eb26abed04fb044d1470f..ce49e2ff8e4046a4a705cb7c0d278eb9b6d6d513 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -1318,7 +1318,7 @@ void Element::detach(const AttachContext& context)
}
if (ElementShadow* shadow = this->shadow()) {
- detachChildrenIfNeeded();
+ detachChildrenIfNeeded(context);
shadow->detach();
esprehn 2013/06/13 18:20:42 You don't correctly handle ShadowRoots, you need t
}
ContainerNode::detach(context);

Powered by Google App Engine
This is Rietveld 408576698