Issue 16950029: Turn off devices with low battery and don't fail device status step.

Issue 16950029: Turn off devices with low battery and don't fail device status step. (Closed)

Created:
7 years, 6 months ago by navabi

Modified:
7 years, 6 months ago

Reviewers:
cmp, craigdh, Isaac (away), frankf, Siva Chandra

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Turn off devices with low battery and don't fail device status step. BUG=224004 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208088

Patch Set 2 : Add conditional to only turn off low battery devices, not all devices. #

Total comments: 1

Patch Set 3 : Add TODO to use android_commands. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	build/android/device_status_check.py	View	1 2	3 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

lgtm -- but lets make sure this sense an email alert when device is taken ...

7 years, 6 months ago (2013-06-21 23:59:33 UTC) #2

frankf

https://codereview.chromium.org/16950029/diff/1/build/android/device_status_check.py File build/android/device_status_check.py (right): https://codereview.chromium.org/16950029/diff/1/build/android/device_status_check.py#newcode89 build/android/device_status_check.py:89: AdbShellCmd('reboot -p') Why don't you use device_adb instead of ...

7 years, 6 months ago (2013-06-22 00:03:50 UTC) #3

navabi

On 2013/06/22 00:03:50, frankf wrote: > https://codereview.chromium.org/16950029/diff/1/build/android/device_status_check.py > File build/android/device_status_check.py (right): > > https://codereview.chromium.org/16950029/diff/1/build/android/device_status_check.py#newcode89 > ...

7 years, 6 months ago (2013-06-22 00:10:13 UTC) #4

navabi

https://codereview.chromium.org/16950029/diff/6001/build/android/device_status_check.py File build/android/device_status_check.py (right): https://codereview.chromium.org/16950029/diff/6001/build/android/device_status_check.py#newcode75 build/android/device_status_check.py:75: errors += ['Device critically low in battery. Turning off ...

7 years, 6 months ago (2013-06-22 00:12:18 UTC) #5

frankf

On 2013/06/22 00:12:18, navabi wrote: > https://codereview.chromium.org/16950029/diff/6001/build/android/device_status_check.py > File build/android/device_status_check.py (right): > > https://codereview.chromium.org/16950029/diff/6001/build/android/device_status_check.py#newcode75 > ...

7 years, 6 months ago (2013-06-22 00:13:29 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16950029/6001

7 years, 6 months ago (2013-06-22 00:13:32 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16950029/13001

7 years, 6 months ago (2013-06-22 00:16:37 UTC) #8

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests, content_browsertests, nacl_integration, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=141879

7 years, 6 months ago (2013-06-22 03:11:38 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16950029/13001

7 years, 6 months ago (2013-06-22 18:52:03 UTC) #10

Message was sent while issue was closed.

Change committed as 208088

Expand Messages | Collapse Messages