Issue 16950027: Move ComputeDirectorySize to the base namespace.

Issue 16950027: Move ComputeDirectorySize to the base namespace. (Closed)

Created:
7 years, 6 months ago by brettw

Modified:
7 years, 6 months ago

Reviewers:
tfarina

CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kinuko+watch, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move ComputeDirectorySize to the base namespace. BUG= TBR=tfarina Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208091

Patch Set 1 #

Patch Set 2 : git try #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -28 lines)			Patch
M	base/file_util.h	View		1 chunk	+11 lines, -10 lines	0 comments	Download
M	base/file_util.cc	View		3 chunks	+20 lines, -12 lines	0 comments	Download
M	base/file_util_unittest.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
M	base/file_util_win.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/contacts/contact_database.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/diagnostics/recon_diagnostics.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_context_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/browser/fileapi/sandbox_file_system_test_helper.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

lgtm https://codereview.chromium.org/16950027/diff/3002/base/file_util_unittest.cc File base/file_util_unittest.cc (right): https://codereview.chromium.org/16950027/diff/3002/base/file_util_unittest.cc#newcode339 base/file_util_unittest.cc:339: int64 computed_size = base::ComputeDirectorySize(temp_dir_.path()); to make our lives ...

7 years, 6 months ago (2013-06-21 23:30:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/16950027/3002

7 years, 6 months ago (2013-06-22 19:02:42 UTC) #3

Message was sent while issue was closed.

Change committed as 208091

Expand Messages | Collapse Messages